From: David Miller <davem@davemloft.net>
To: dan.j.williams@intel.com
Cc: netdev@vger.kernel.org, ebiederm@xmission.com,
stable@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mpls, nospec: Sanitize array index in mpls_label_ok()
Date: Thu, 08 Feb 2018 15:24:30 -0500 (EST) [thread overview]
Message-ID: <20180208.152430.815938637029162565.davem@davemloft.net> (raw)
In-Reply-To: <151807166425.3807.8813780890075479680.stgit@dwillia2-desk3.amr.corp.intel.com>
From: Dan Williams <dan.j.williams@intel.com>
Date: Wed, 07 Feb 2018 22:34:24 -0800
> mpls_label_ok() validates that the 'platform_label' array index from a
> userspace netlink message payload is valid. Under speculation the
> mpls_label_ok() result may not resolve in the CPU pipeline until after
> the index is used to access an array element. Sanitize the index to zero
> to prevent userspace-controlled arbitrary out-of-bounds speculation, a
> precursor for a speculative execution side channel vulnerability.
>
> Cc: <stable@vger.kernel.org>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Eric W. Biederman <ebiederm@xmission.com>
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Applied, thank you.
prev parent reply other threads:[~2018-02-08 20:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-08 6:34 [PATCH] mpls, nospec: Sanitize array index in mpls_label_ok() Dan Williams
2018-02-08 20:24 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180208.152430.815938637029162565.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dan.j.williams@intel.com \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).