From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, oss-drivers@netronome.com,
Jakub Kicinski <jakub.kicinski@netronome.com>
Subject: [PATCH net 0/5] nfp: fix disabling TC offloads in flower, max TSO segs and module version
Date: Wed, 7 Feb 2018 20:55:21 -0800 [thread overview]
Message-ID: <20180208045526.11282-1-jakub.kicinski@netronome.com> (raw)
Hi!
This set corrects the way nfp deals with the NETIF_F_HW_TC flag.
It has slipped the review that flower offload does not currently
refuse disabling this flag when filter offload is active.
nfp's flower offload does not actually keep track of how many filters
for each port are offloaded. The accounting of the number of filters
is added to the nfp core structures, and BPF moved to use these
structures as well.
If users are allowed to disable TC offloads while filters are active,
not only is it incorrect behaviour, but actually the NFP will never
be told to remove the flows, leading to use-after-free when stats
arrive.
Fourth patch makes sure we declare the max number of TSO segments.
FW should drop longer packets cleanly (otherwise this would be a
security problem for untrusted VFs) but dropping longer TSO frames
is not nice and driver should prevent them from being generated.
Last small addition populates MODULE_VERSION with kernel version.
Jakub Kicinski (5):
nfp: bpf: require ETH table
nfp: don't advertise hw-tc-offload on non-port netdevs
nfp: forbid disabling hw-tc-offload on representors while offload
active
nfp: limit the number of TSO segments
nfp: populate MODULE_VERSION
drivers/net/ethernet/netronome/nfp/bpf/main.c | 21 +++++++++++++--------
drivers/net/ethernet/netronome/nfp/flower/offload.c | 4 ++++
drivers/net/ethernet/netronome/nfp/nfp_app.h | 9 ---------
drivers/net/ethernet/netronome/nfp/nfp_main.c | 1 +
drivers/net/ethernet/netronome/nfp/nfp_net_common.c | 11 ++++++-----
drivers/net/ethernet/netronome/nfp/nfp_net_ctrl.h | 5 ++++-
drivers/net/ethernet/netronome/nfp/nfp_net_repr.c | 1 +
drivers/net/ethernet/netronome/nfp/nfp_port.c | 18 ++++++++++++++++++
drivers/net/ethernet/netronome/nfp/nfp_port.h | 6 ++++++
9 files changed, 53 insertions(+), 23 deletions(-)
--
2.15.1
next reply other threads:[~2018-02-08 4:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-08 4:55 Jakub Kicinski [this message]
2018-02-08 4:55 ` [PATCH net 1/5] nfp: bpf: require ETH table Jakub Kicinski
2018-02-08 4:55 ` [PATCH net 2/5] nfp: don't advertise hw-tc-offload on non-port netdevs Jakub Kicinski
2018-02-08 4:55 ` [PATCH net 3/5] nfp: forbid disabling hw-tc-offload on representors while offload active Jakub Kicinski
2018-02-08 4:55 ` [PATCH net 4/5] nfp: limit the number of TSO segments Jakub Kicinski
2018-02-08 12:34 ` [oss-drivers] " Simon Horman
2018-02-08 4:55 ` [PATCH net 5/5] nfp: populate MODULE_VERSION Jakub Kicinski
2018-02-08 12:35 ` [oss-drivers] " Simon Horman
2018-02-08 15:03 ` [PATCH net 0/5] nfp: fix disabling TC offloads in flower, max TSO segs and module version David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180208045526.11282-1-jakub.kicinski@netronome.com \
--to=jakub.kicinski@netronome.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).