* [PATCH v2] rtlwifi: rtl8192cu: Remove variable self-assignment in rf.c
@ 2018-02-09 0:57 Matthias Kaehlcke
2018-02-09 1:15 ` Larry Finger
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Matthias Kaehlcke @ 2018-02-09 0:57 UTC (permalink / raw)
To: Ping-Ke Shih, Larry Finger, Kalle Valo
Cc: linux-wireless, netdev, linux-kernel, Guenter Roeck,
Justin TerAvest, Craig Bergstrom, Matthias Kaehlcke
In _rtl92c_get_txpower_writeval_by_regulatory() the variable writeVal
is assigned to itself in an if ... else statement, apparently only to
document that the branch condition is handled and that a previously read
value should be returned unmodified. The self-assignment causes clang to
raise the following warning:
drivers/net/wireless/realtek/rtlwifi/rtl8192cu/rf.c:304:13:
error: explicitly assigning value of variable of type 'u32'
(aka 'unsigned int') to itself [-Werror,-Wself-assign]
writeVal = writeVal;
Delete the branch with the self-assignment.
Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
---
Changes in v2:
- Delete the 'else if' branch entirely
drivers/net/wireless/realtek/rtlwifi/rtl8192cu/rf.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/rf.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/rf.c
index 9cff6bc4049c..cf551785eb08 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/rf.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/rf.c
@@ -299,9 +299,6 @@ static void _rtl92c_get_txpower_writeval_by_regulatory(struct ieee80211_hw *hw,
writeVal = 0x00000000;
if (rtlpriv->dm.dynamic_txhighpower_lvl == TXHIGHPWRLEVEL_BT1)
writeVal = writeVal - 0x06060606;
- else if (rtlpriv->dm.dynamic_txhighpower_lvl ==
- TXHIGHPWRLEVEL_BT2)
- writeVal = writeVal;
*(p_outwriteval + rf) = writeVal;
}
}
--
2.16.0.rc1.238.g530d649a79-goog
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v2] rtlwifi: rtl8192cu: Remove variable self-assignment in rf.c
2018-02-09 0:57 [PATCH v2] rtlwifi: rtl8192cu: Remove variable self-assignment in rf.c Matthias Kaehlcke
@ 2018-02-09 1:15 ` Larry Finger
2018-02-09 1:24 ` Guenter Roeck
2018-02-27 16:17 ` [v2] " Kalle Valo
2 siblings, 0 replies; 4+ messages in thread
From: Larry Finger @ 2018-02-09 1:15 UTC (permalink / raw)
To: Matthias Kaehlcke, Ping-Ke Shih, Kalle Valo
Cc: linux-wireless, netdev, linux-kernel, Guenter Roeck,
Justin TerAvest, Craig Bergstrom
On 02/08/2018 06:57 PM, Matthias Kaehlcke wrote:
> In _rtl92c_get_txpower_writeval_by_regulatory() the variable writeVal
> is assigned to itself in an if ... else statement, apparently only to
> document that the branch condition is handled and that a previously read
> value should be returned unmodified. The self-assignment causes clang to
> raise the following warning:
>
> drivers/net/wireless/realtek/rtlwifi/rtl8192cu/rf.c:304:13:
> error: explicitly assigning value of variable of type 'u32'
> (aka 'unsigned int') to itself [-Werror,-Wself-assign]
> writeVal = writeVal;
>
> Delete the branch with the self-assignment.
>
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> ---
> Changes in v2:
> - Delete the 'else if' branch entirely
>
> drivers/net/wireless/realtek/rtlwifi/rtl8192cu/rf.c | 3 ---
> 1 file changed, 3 deletions(-)
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
>
> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/rf.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/rf.c
> index 9cff6bc4049c..cf551785eb08 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/rf.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/rf.c
> @@ -299,9 +299,6 @@ static void _rtl92c_get_txpower_writeval_by_regulatory(struct ieee80211_hw *hw,
> writeVal = 0x00000000;
> if (rtlpriv->dm.dynamic_txhighpower_lvl == TXHIGHPWRLEVEL_BT1)
> writeVal = writeVal - 0x06060606;
> - else if (rtlpriv->dm.dynamic_txhighpower_lvl ==
> - TXHIGHPWRLEVEL_BT2)
> - writeVal = writeVal;
> *(p_outwriteval + rf) = writeVal;
> }
> }
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] rtlwifi: rtl8192cu: Remove variable self-assignment in rf.c
2018-02-09 0:57 [PATCH v2] rtlwifi: rtl8192cu: Remove variable self-assignment in rf.c Matthias Kaehlcke
2018-02-09 1:15 ` Larry Finger
@ 2018-02-09 1:24 ` Guenter Roeck
2018-02-27 16:17 ` [v2] " Kalle Valo
2 siblings, 0 replies; 4+ messages in thread
From: Guenter Roeck @ 2018-02-09 1:24 UTC (permalink / raw)
To: Matthias Kaehlcke
Cc: Ping-Ke Shih, Larry Finger, Kalle Valo, linux-wireless, netdev,
linux-kernel, Guenter Roeck, Justin TerAvest, Craig Bergstrom
On Thu, Feb 8, 2018 at 4:57 PM, Matthias Kaehlcke <mka@chromium.org> wrote:
> In _rtl92c_get_txpower_writeval_by_regulatory() the variable writeVal
> is assigned to itself in an if ... else statement, apparently only to
> document that the branch condition is handled and that a previously read
> value should be returned unmodified. The self-assignment causes clang to
> raise the following warning:
>
> drivers/net/wireless/realtek/rtlwifi/rtl8192cu/rf.c:304:13:
> error: explicitly assigning value of variable of type 'u32'
> (aka 'unsigned int') to itself [-Werror,-Wself-assign]
> writeVal = writeVal;
>
> Delete the branch with the self-assignment.
>
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
Reviewed-by: Guenter Roeck <groeck@chromium.org>
> ---
> Changes in v2:
> - Delete the 'else if' branch entirely
>
> drivers/net/wireless/realtek/rtlwifi/rtl8192cu/rf.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/rf.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/rf.c
> index 9cff6bc4049c..cf551785eb08 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/rf.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/rf.c
> @@ -299,9 +299,6 @@ static void _rtl92c_get_txpower_writeval_by_regulatory(struct ieee80211_hw *hw,
> writeVal = 0x00000000;
> if (rtlpriv->dm.dynamic_txhighpower_lvl == TXHIGHPWRLEVEL_BT1)
> writeVal = writeVal - 0x06060606;
> - else if (rtlpriv->dm.dynamic_txhighpower_lvl ==
> - TXHIGHPWRLEVEL_BT2)
> - writeVal = writeVal;
> *(p_outwriteval + rf) = writeVal;
> }
> }
> --
> 2.16.0.rc1.238.g530d649a79-goog
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [v2] rtlwifi: rtl8192cu: Remove variable self-assignment in rf.c
2018-02-09 0:57 [PATCH v2] rtlwifi: rtl8192cu: Remove variable self-assignment in rf.c Matthias Kaehlcke
2018-02-09 1:15 ` Larry Finger
2018-02-09 1:24 ` Guenter Roeck
@ 2018-02-27 16:17 ` Kalle Valo
2 siblings, 0 replies; 4+ messages in thread
From: Kalle Valo @ 2018-02-27 16:17 UTC (permalink / raw)
To: Matthias Kaehlcke
Cc: Ping-Ke Shih, Larry Finger, linux-wireless, netdev, linux-kernel,
Guenter Roeck, Justin TerAvest, Craig Bergstrom,
Matthias Kaehlcke
Matthias Kaehlcke <mka@chromium.org> wrote:
> In _rtl92c_get_txpower_writeval_by_regulatory() the variable writeVal
> is assigned to itself in an if ... else statement, apparently only to
> document that the branch condition is handled and that a previously read
> value should be returned unmodified. The self-assignment causes clang to
> raise the following warning:
>
> drivers/net/wireless/realtek/rtlwifi/rtl8192cu/rf.c:304:13:
> error: explicitly assigning value of variable of type 'u32'
> (aka 'unsigned int') to itself [-Werror,-Wself-assign]
> writeVal = writeVal;
>
> Delete the branch with the self-assignment.
>
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
> Reviewed-by: Guenter Roeck <groeck@chromium.org>
Patch applied to wireless-drivers-next.git, thanks.
fb239c1209bb rtlwifi: rtl8192cu: Remove variable self-assignment in rf.c
--
https://patchwork.kernel.org/patch/10208183/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-02-27 16:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-02-09 0:57 [PATCH v2] rtlwifi: rtl8192cu: Remove variable self-assignment in rf.c Matthias Kaehlcke
2018-02-09 1:15 ` Larry Finger
2018-02-09 1:24 ` Guenter Roeck
2018-02-27 16:17 ` [v2] " Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).