From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesper Dangaard Brouer Subject: Re: [bpf-next V3 PATCH 0/5] tools/libbpf improvements and selftests Date: Fri, 9 Feb 2018 09:18:47 +0100 Message-ID: <20180209091847.71b7e9f8@redhat.com> References: <151809046123.4625.11746882480100311060.stgit@firesoul> <09906a95-00ed-949d-6287-c78babf20dca@iogearbox.net> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, Daniel Borkmann , Alexei Starovoitov , wangnan0@huawei.com, jakub.kicinski@netronome.com, joe@ovn.org, acme@redhat.com, eric@regit.org, yhs@fb.com, brouer@redhat.com To: Daniel Borkmann Return-path: Received: from mx3-rdu2.redhat.com ([66.187.233.73]:45860 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750945AbeBIISw (ORCPT ); Fri, 9 Feb 2018 03:18:52 -0500 In-Reply-To: <09906a95-00ed-949d-6287-c78babf20dca@iogearbox.net> Sender: netdev-owner@vger.kernel.org List-ID: On Fri, 9 Feb 2018 02:32:27 +0100 Daniel Borkmann wrote: > On 02/08/2018 12:48 PM, Jesper Dangaard Brouer wrote: > > While playing with using libbpf for the Suricata project, we had > > issues LLVM >= 4.0.1 generating ELF files that could not be loaded > > with libbpf (tools/lib/bpf/). > > > > During the troubleshooting phase, I wrote a test program and improved > > the debugging output in libbpf. I turned this into a selftests > > program, and it also serves as a code example for libbpf in itself. > > > > I discovered that there are at least three ELF load issues with > > libbpf. I left them as TODO comments in (tools/testing/selftests/bpf) > > test_libbpf.sh. I've only fixed the load issue with eh_frames, and > > other types of relo-section that does not have exec flags. We can > > work on the other issues later. > > Applied it to bpf tree, thanks Jesper! Thank you for applying this the 'bpf' tree! -- appreciate it! -- Best regards, Jesper Dangaard Brouer MSc.CS, Principal Kernel Engineer at Red Hat LinkedIn: http://www.linkedin.com/in/brouer