From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] mvpp2: fix multicast address filter Date: Sun, 11 Feb 2018 22:37:51 -0500 (EST) Message-ID: <20180211.223751.2130845243634593943.davem@davemloft.net> References: Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: mw@semihalf.com, rmk@armlinux.org.uk, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org To: mpatocka@redhat.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:47608 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932310AbeBLDhx (ORCPT ); Sun, 11 Feb 2018 22:37:53 -0500 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: From: Mikulas Patocka Date: Sun, 11 Feb 2018 18:10:28 -0500 (EST) > IPv6 doesn't work on the MacchiatoBIN board. It is caused by broken > multicast address filter in the mvpp2 driver. > > The driver loads doesn't load any multicast entries if "allmulti" is not > set. This condition should be reversed. > > The condition !netdev_mc_empty(dev) is useless (because > netdev_for_each_mc_addr is nop if the list is empty). > > This patch also fixes a possible overflow of the multicast list - if > mvpp2_prs_mac_da_accept fails, we set the allmulti flag and retry. > > Signed-off-by: Mikulas Patocka Applied, thanks.