From: David Miller <davem@davemloft.net>
To: ktkhai@virtuozzo.com
Cc: ying.xue@windriver.com, jon.maloy@ericsson.com,
netdev@vger.kernel.org, syzkaller-bugs@googlegroups.com,
tipc-discussion@lists.sourceforge.net
Subject: Re: [PATCH net v2] tipc: fix missing RTNL lock protection during setting link properties
Date: Mon, 12 Feb 2018 10:08:14 -0500 (EST) [thread overview]
Message-ID: <20180212.100814.1679806505862335377.davem@davemloft.net> (raw)
In-Reply-To: <147fc60b-df6b-c8ab-8a10-e57e310f65bf@virtuozzo.com>
From: Kirill Tkhai <ktkhai@virtuozzo.com>
Date: Mon, 12 Feb 2018 13:10:34 +0300
> This err branch looks excess. It was before your patch, but in case of you change this place,
> can't we stop having it? it looks like we can simply do the below here:
>
> err = tipc_enable_bearer(net, bearer, domain, prio, attrs);
> return err;
Or even better, straight:
return tipc_enable_bearer(net, bearer, domain, prio, attrs);
prev parent reply other threads:[~2018-02-12 15:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-12 8:56 [PATCH net v2] tipc: fix missing RTNL lock protection during setting link properties Ying Xue
2018-02-12 10:10 ` Kirill Tkhai
2018-02-12 15:08 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180212.100814.1679806505862335377.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jon.maloy@ericsson.com \
--cc=ktkhai@virtuozzo.com \
--cc=netdev@vger.kernel.org \
--cc=syzkaller-bugs@googlegroups.com \
--cc=tipc-discussion@lists.sourceforge.net \
--cc=ying.xue@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).