From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [PATCH net v2] tipc: fix missing RTNL lock protection during
 setting link properties
Date: Mon, 12 Feb 2018 10:08:14 -0500 (EST)
Message-ID: <20180212.100814.1679806505862335377.davem@davemloft.net>
References: <1518425791-5622-1-git-send-email-ying.xue@windriver.com>
        <147fc60b-df6b-c8ab-8a10-e57e310f65bf@virtuozzo.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: ying.xue@windriver.com, jon.maloy@ericsson.com,
        netdev@vger.kernel.org, syzkaller-bugs@googlegroups.com,
        tipc-discussion@lists.sourceforge.net
To: ktkhai@virtuozzo.com
Return-path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([184.105.139.130]:53598 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752203AbeBLPIV (ORCPT
        <rfc822;netdev@vger.kernel.org>); Mon, 12 Feb 2018 10:08:21 -0500
In-Reply-To: <147fc60b-df6b-c8ab-8a10-e57e310f65bf@virtuozzo.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Kirill Tkhai <ktkhai@virtuozzo.com>
Date: Mon, 12 Feb 2018 13:10:34 +0300

> This err branch looks excess. It was before your patch, but in case of you change this place,
> can't we stop having it? it looks like we can simply do the below here:
> 
> 	err = tipc_enable_bearer(net, bearer, domain, prio, attrs);
> 	return err;

Or even better, straight:

	return tipc_enable_bearer(net, bearer, domain, prio, attrs);