From: David Miller <davem@davemloft.net>
To: marcelo.leitner@gmail.com
Cc: lucien.xin@gmail.com, netdev@vger.kernel.org,
linux-sctp@vger.kernel.org, nhorman@tuxdriver.com
Subject: Re: [PATCH net] sctp: rename sctp_diag.c as diag.c
Date: Mon, 12 Feb 2018 10:12:24 -0500 (EST) [thread overview]
Message-ID: <20180212.101224.44294606381993057.davem@davemloft.net> (raw)
In-Reply-To: <20180212123704.GL7402@localhost.localdomain>
From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Date: Mon, 12 Feb 2018 10:37:04 -0200
> On Mon, Feb 12, 2018 at 06:32:30PM +0800, Xin Long wrote:
>> Remove sctp_ prefix for diag file, to keep consistent with other
>> files' names, while at it, also to add file comments for diag.c.
>
> Okay but this should be a two-patches series then. The changes made
> with the rename are hard to find/follow later.
Agreed, the file move should be a separate change from and
modifications to the file itself.
next prev parent reply other threads:[~2018-02-12 15:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-12 10:32 [PATCH net] sctp: rename sctp_diag.c as diag.c Xin Long
2018-02-12 12:37 ` Marcelo Ricardo Leitner
2018-02-12 15:12 ` David Miller [this message]
2018-02-13 7:24 ` Xin Long
2018-02-12 14:18 ` Neil Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180212.101224.44294606381993057.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-sctp@vger.kernel.org \
--cc=lucien.xin@gmail.com \
--cc=marcelo.leitner@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).