From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net] sctp: remove the useless check in sctp_renege_events Date: Mon, 12 Feb 2018 11:47:27 -0500 (EST) Message-ID: <20180212.114727.1546226581735499348.davem@davemloft.net> References: <8db12ad85c54e5b56bc871e977bd71a1f6ea2e99.1518431484.git.lucien.xin@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, linux-sctp@vger.kernel.org, marcelo.leitner@gmail.com, nhorman@tuxdriver.com To: lucien.xin@gmail.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:54720 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753788AbeBLQr3 (ORCPT ); Mon, 12 Feb 2018 11:47:29 -0500 In-Reply-To: <8db12ad85c54e5b56bc871e977bd71a1f6ea2e99.1518431484.git.lucien.xin@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Xin Long Date: Mon, 12 Feb 2018 18:31:24 +0800 > Remove the 'if (chunk)' check in sctp_renege_events for idata process, > as all renege commands are generated in sctp_eat_data and it can't be > NULL. > > The same thing we already did for common data in sctp_ulpq_renege. > > Fixes: 94014e8d871a ("sctp: implement renege_events for sctp_stream_interleave") > Signed-off-by: Xin Long Applied.