From: David Miller <davem@davemloft.net>
To: mika.westerberg@linux.intel.com
Cc: michael.jamet@intel.com, yehezkel.bernat@intel.com,
netdev@vger.kernel.org
Subject: Re: [PATCH net 2/2] net: thunderbolt: Run disconnect flow asynchronously when logout is received
Date: Mon, 12 Feb 2018 12:03:25 -0500 (EST) [thread overview]
Message-ID: <20180212.120325.2105987484810673757.davem@davemloft.net> (raw)
In-Reply-To: <20180212141020.78136-2-mika.westerberg@linux.intel.com>
From: Mika Westerberg <mika.westerberg@linux.intel.com>
Date: Mon, 12 Feb 2018 17:10:20 +0300
> The control channel calls registered callbacks when control messages
> such as XDomain protocol messages are received. The control channel
> handling is done in a worker running on system workqueue which means the
> networking driver can't run tear down flow which includes sending
> disconnect request and waiting for a reply in the same worker. Otherwise
> reply is never received (as the work is already running) and the
> operation times out.
>
> To fix this run disconnect ThunderboltIP flow asynchronously once
> ThunderboltIP logout message is received.
>
> Fixes: e69b6c02b4c3 ("net: Add support for networking over Thunderbolt cable")
> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Also applied, thank you.
next prev parent reply other threads:[~2018-02-12 17:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-12 14:10 [PATCH net 1/2] net: thunderbolt: Tear down connection properly on suspend Mika Westerberg
2018-02-12 14:10 ` [PATCH net 2/2] net: thunderbolt: Run disconnect flow asynchronously when logout is received Mika Westerberg
2018-02-12 17:03 ` David Miller [this message]
2018-02-12 17:03 ` [PATCH net 1/2] net: thunderbolt: Tear down connection properly on suspend David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180212.120325.2105987484810673757.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=michael.jamet@intel.com \
--cc=mika.westerberg@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=yehezkel.bernat@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).