From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net 2/2] net: thunderbolt: Run disconnect flow asynchronously when logout is received Date: Mon, 12 Feb 2018 12:03:25 -0500 (EST) Message-ID: <20180212.120325.2105987484810673757.davem@davemloft.net> References: <20180212141020.78136-1-mika.westerberg@linux.intel.com> <20180212141020.78136-2-mika.westerberg@linux.intel.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: michael.jamet@intel.com, yehezkel.bernat@intel.com, netdev@vger.kernel.org To: mika.westerberg@linux.intel.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:55032 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751108AbeBLRD0 (ORCPT ); Mon, 12 Feb 2018 12:03:26 -0500 In-Reply-To: <20180212141020.78136-2-mika.westerberg@linux.intel.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Mika Westerberg Date: Mon, 12 Feb 2018 17:10:20 +0300 > The control channel calls registered callbacks when control messages > such as XDomain protocol messages are received. The control channel > handling is done in a worker running on system workqueue which means the > networking driver can't run tear down flow which includes sending > disconnect request and waiting for a reply in the same worker. Otherwise > reply is never received (as the work is already running) and the > operation times out. > > To fix this run disconnect ThunderboltIP flow asynchronously once > ThunderboltIP logout message is received. > > Fixes: e69b6c02b4c3 ("net: Add support for networking over Thunderbolt cable") > Signed-off-by: Mika Westerberg Also applied, thank you.