netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: atul.gupta@chelsio.com
Cc: davejwatson@fb.com, herbert@gondor.apana.org.au,
	sd@queasysnail.net, linux-crypto@vger.kernel.org,
	netdev@vger.kernel.org, ganeshgr@chelsio.com
Subject: Re: [Crypto v4 01/12] tls: tls_device struct to register TLS drivers
Date: Mon, 12 Feb 2018 14:45:16 -0500 (EST)	[thread overview]
Message-ID: <20180212.144516.999297130875943550.davem@davemloft.net> (raw)
In-Reply-To: <1518437028-14250-1-git-send-email-atul.gupta@chelsio.com>

From: Atul Gupta <atul.gupta@chelsio.com>
Date: Mon, 12 Feb 2018 17:33:48 +0530

> +	/* When calling get_netdev, the HW vendor's driver should return the
> +	 * net device of device @device at port @port_num or NULL if such
> +	 * a net device doesn't exist
> +	 */
> +	struct net_device *(*netdev)(struct tls_device *device,
> +				     struct net_device *netdev);

I do not see a "port_num" parameter or structure member anywhere.

Please update this comment to match reality.

Thank you.

      reply	other threads:[~2018-02-12 19:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-12 12:03 [Crypto v4 01/12] tls: tls_device struct to register TLS drivers Atul Gupta
2018-02-12 19:45 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180212.144516.999297130875943550.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=atul.gupta@chelsio.com \
    --cc=davejwatson@fb.com \
    --cc=ganeshgr@chelsio.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=sd@queasysnail.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).