From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next 0/4] selftests: fib_tests: simplifications, verbosity and a race Date: Tue, 13 Feb 2018 14:34:48 -0500 (EST) Message-ID: <20180213.143448.27158523498798506.davem@davemloft.net> References: <20180213163736.1538-1-dsahern@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, idosch@mellanox.com To: dsahern@gmail.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:43740 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965313AbeBMTex (ORCPT ); Tue, 13 Feb 2018 14:34:53 -0500 In-Reply-To: <20180213163736.1538-1-dsahern@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: From: David Ahern Date: Tue, 13 Feb 2018 08:37:32 -0800 > Improve efficiency of fib_tests.sh and make the test result more verbose, > from this summary: > $ fib_tests.sh is failing in a VM: > $ fib_tests.sh > Running netdev unregister tests > PASS: unicast route test > PASS: multipath route test > Running netdev down tests > PASS: unicast route test > PASS: multipath route test > Running netdev carrier change tests > PASS: local route carrier test > FAIL: unicast route carrier test > > where a single entry actually corresponds to many checks to a much more > verbse output that clarifies test cases: > $fib_tests.sh > Single path route carrier test > .... > Carrier down > IPv4 fibmatch [ OK ] > IPv6 fibmatch [ OK ] > IPv4 linkdown flag set [FAIL] > IPv6 linkdown flag set [FAIL] > Second address added with carrier down > IPv4 fibmatch [ OK ] > IPv6 fibmatch [ OK ] > IPv4 linkdown flag set [FAIL] > IPv6 linkdown flag set [ OK ] > > And then fix the race in changing carrier down on dummy device to checking > the corresponding routes. Looks great, series applied, thanks David.