From: David Miller <davem@davemloft.net>
To: dsahern@gmail.com
Cc: netdev@vger.kernel.org, roopa@cumulusnetworks.com
Subject: Re: [PATCH net-next] net: Move ipv4 set_lwt_redirect helper to lwtunnel
Date: Tue, 13 Feb 2018 14:49:47 -0500 (EST) [thread overview]
Message-ID: <20180213.144947.1026417908602250422.davem@davemloft.net> (raw)
In-Reply-To: <20180213164550.1865-1-dsahern@gmail.com>
From: David Ahern <dsahern@gmail.com>
Date: Tue, 13 Feb 2018 08:45:50 -0800
> @@ -127,6 +127,19 @@ int lwtunnel_output(struct net *net, struct sock *sk, struct sk_buff *skb);
> int lwtunnel_input(struct sk_buff *skb);
> int lwtunnel_xmit(struct sk_buff *skb);
>
> +static inline void lwtunnel_set_redirect(struct dst_entry *dst)
> +{
> + if (dst->lwtstate) {
This test is new, and doesn't exist in the ipv4 nor the ipv6 code you are
deriving this from.
If it is needed, explain why.
Thank you.
next prev parent reply other threads:[~2018-02-13 19:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-13 16:45 [PATCH net-next] net: Move ipv4 set_lwt_redirect helper to lwtunnel David Ahern
2018-02-13 19:49 ` David Miller [this message]
2018-02-13 19:52 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180213.144947.1026417908602250422.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=roopa@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).