From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Ahern Subject: [PATCH RFC net-next 1/7] net/ipv4: Pass net to fib_multipath_hash instead of fib_info Date: Mon, 12 Feb 2018 16:05:56 -0800 Message-ID: <20180213000602.12150-2-dsahern@gmail.com> References: <20180213000602.12150-1-dsahern@gmail.com> Cc: roopa@cumulusnetworks.com, nikolay@cumulusnetworks.com, idosch@mellanox.com, David Ahern To: netdev@vger.kernel.org Return-path: Received: from mail-io0-f194.google.com ([209.85.223.194]:41015 "EHLO mail-io0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932839AbeBMAGL (ORCPT ); Mon, 12 Feb 2018 19:06:11 -0500 Received: by mail-io0-f194.google.com with SMTP id f4so19345684ioh.8 for ; Mon, 12 Feb 2018 16:06:10 -0800 (PST) In-Reply-To: <20180213000602.12150-1-dsahern@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: fib_multipath_hash only needs net struct to check a sysctl. Make it clear by passing net instead of fib_info. In the need this allows alignment between the ipv4 and ipv6 versions. Signed-off-by: David Ahern --- include/net/ip_fib.h | 2 +- net/ipv4/fib_semantics.c | 2 +- net/ipv4/route.c | 5 ++--- 3 files changed, 4 insertions(+), 5 deletions(-) diff --git a/include/net/ip_fib.h b/include/net/ip_fib.h index f80524396c06..0472bf774a5a 100644 --- a/include/net/ip_fib.h +++ b/include/net/ip_fib.h @@ -370,7 +370,7 @@ int fib_sync_down_addr(struct net_device *dev, __be32 local); int fib_sync_up(struct net_device *dev, unsigned int nh_flags); #ifdef CONFIG_IP_ROUTE_MULTIPATH -int fib_multipath_hash(const struct fib_info *fi, const struct flowi4 *fl4, +int fib_multipath_hash(const struct net *net, const struct flowi4 *fl4, const struct sk_buff *skb); #endif void fib_select_multipath(struct fib_result *res, int hash); diff --git a/net/ipv4/fib_semantics.c b/net/ipv4/fib_semantics.c index c586597da20d..e22443244190 100644 --- a/net/ipv4/fib_semantics.c +++ b/net/ipv4/fib_semantics.c @@ -1767,7 +1767,7 @@ void fib_select_path(struct net *net, struct fib_result *res, #ifdef CONFIG_IP_ROUTE_MULTIPATH if (res->fi->fib_nhs > 1 && oif_check) { - int h = fib_multipath_hash(res->fi, fl4, skb); + int h = fib_multipath_hash(res->fi->fib_net, fl4, skb); fib_select_multipath(res, h); } diff --git a/net/ipv4/route.c b/net/ipv4/route.c index 49cc1c1df1ba..975c4b7cff07 100644 --- a/net/ipv4/route.c +++ b/net/ipv4/route.c @@ -1797,10 +1797,9 @@ static void ip_multipath_l3_keys(const struct sk_buff *skb, } /* if skb is set it will be used and fl4 can be NULL */ -int fib_multipath_hash(const struct fib_info *fi, const struct flowi4 *fl4, +int fib_multipath_hash(const struct net *net, const struct flowi4 *fl4, const struct sk_buff *skb) { - struct net *net = fi->fib_net; struct flow_keys hash_keys; u32 mhash; @@ -1856,7 +1855,7 @@ static int ip_mkroute_input(struct sk_buff *skb, { #ifdef CONFIG_IP_ROUTE_MULTIPATH if (res->fi && res->fi->fib_nhs > 1) { - int h = fib_multipath_hash(res->fi, NULL, skb); + int h = fib_multipath_hash(res->fi->fib_net, NULL, skb); fib_select_multipath(res, h); } -- 2.11.0