From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Ahern Subject: [PATCH RFC net-next 7/7] net: Remove unused get_hash_from_flow functions Date: Mon, 12 Feb 2018 16:06:02 -0800 Message-ID: <20180213000602.12150-8-dsahern@gmail.com> References: <20180213000602.12150-1-dsahern@gmail.com> Cc: roopa@cumulusnetworks.com, nikolay@cumulusnetworks.com, idosch@mellanox.com, David Ahern To: netdev@vger.kernel.org Return-path: Received: from mail-it0-f67.google.com ([209.85.214.67]:35168 "EHLO mail-it0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933008AbeBMAGS (ORCPT ); Mon, 12 Feb 2018 19:06:18 -0500 Received: by mail-it0-f67.google.com with SMTP id e1so8751005ita.0 for ; Mon, 12 Feb 2018 16:06:18 -0800 (PST) In-Reply-To: <20180213000602.12150-1-dsahern@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: __get_hash_from_flowi6 is still used for flowlabels, but the IPv4 variant and the wrappers to both are not used. Remove them. Signed-off-by: David Ahern --- include/net/flow.h | 15 --------------- net/core/flow_dissector.c | 16 ---------------- 2 files changed, 31 deletions(-) diff --git a/include/net/flow.h b/include/net/flow.h index f1624fd5b1d0..871c27af6577 100644 --- a/include/net/flow.h +++ b/include/net/flow.h @@ -221,21 +221,6 @@ static inline unsigned int flow_key_size(u16 family) } __u32 __get_hash_from_flowi6(const struct flowi6 *fl6, struct flow_keys *keys); - -static inline __u32 get_hash_from_flowi6(const struct flowi6 *fl6) -{ - struct flow_keys keys; - - return __get_hash_from_flowi6(fl6, &keys); -} - __u32 __get_hash_from_flowi4(const struct flowi4 *fl4, struct flow_keys *keys); -static inline __u32 get_hash_from_flowi4(const struct flowi4 *fl4) -{ - struct flow_keys keys; - - return __get_hash_from_flowi4(fl4, &keys); -} - #endif diff --git a/net/core/flow_dissector.c b/net/core/flow_dissector.c index 559db9ea8d86..d29f09bc5ff9 100644 --- a/net/core/flow_dissector.c +++ b/net/core/flow_dissector.c @@ -1341,22 +1341,6 @@ __u32 __get_hash_from_flowi6(const struct flowi6 *fl6, struct flow_keys *keys) } EXPORT_SYMBOL(__get_hash_from_flowi6); -__u32 __get_hash_from_flowi4(const struct flowi4 *fl4, struct flow_keys *keys) -{ - memset(keys, 0, sizeof(*keys)); - - keys->addrs.v4addrs.src = fl4->saddr; - keys->addrs.v4addrs.dst = fl4->daddr; - keys->control.addr_type = FLOW_DISSECTOR_KEY_IPV4_ADDRS; - keys->ports.src = fl4->fl4_sport; - keys->ports.dst = fl4->fl4_dport; - keys->keyid.keyid = fl4->fl4_gre_key; - keys->basic.ip_proto = fl4->flowi4_proto; - - return flow_hash_from_keys(keys); -} -EXPORT_SYMBOL(__get_hash_from_flowi4); - static const struct flow_dissector_key flow_keys_dissector_keys[] = { { .key_id = FLOW_DISSECTOR_KEY_CONTROL, -- 2.11.0