From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Ahern Subject: [PATCH net-next 0/4] selftests: fib_tests: simplifications, verbosity and a race Date: Tue, 13 Feb 2018 08:37:32 -0800 Message-ID: <20180213163736.1538-1-dsahern@gmail.com> Cc: idosch@mellanox.com, David Ahern To: netdev@vger.kernel.org Return-path: Received: from mail-pl0-f44.google.com ([209.85.160.44]:33010 "EHLO mail-pl0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934828AbeBMQhn (ORCPT ); Tue, 13 Feb 2018 11:37:43 -0500 Received: by mail-pl0-f44.google.com with SMTP id t4so6895855plo.0 for ; Tue, 13 Feb 2018 08:37:42 -0800 (PST) Sender: netdev-owner@vger.kernel.org List-ID: Improve efficiency of fib_tests.sh and make the test result more verbose, from this summary: $ fib_tests.sh is failing in a VM: $ fib_tests.sh Running netdev unregister tests PASS: unicast route test PASS: multipath route test Running netdev down tests PASS: unicast route test PASS: multipath route test Running netdev carrier change tests PASS: local route carrier test FAIL: unicast route carrier test where a single entry actually corresponds to many checks to a much more verbse output that clarifies test cases: $fib_tests.sh Single path route carrier test .... Carrier down IPv4 fibmatch [ OK ] IPv6 fibmatch [ OK ] IPv4 linkdown flag set [FAIL] IPv6 linkdown flag set [FAIL] Second address added with carrier down IPv4 fibmatch [ OK ] IPv6 fibmatch [ OK ] IPv4 linkdown flag set [FAIL] IPv6 linkdown flag set [ OK ] And then fix the race in changing carrier down on dummy device to checking the corresponding routes. David Ahern (4): selftests: fib_tests: simplify ip commands in a namespace selftests: fib_tests: Make test results more verbose selftests: fib_tests: Move admin of dummy0 to helpers selftests: fib_tests: sleep after changing carrier tools/testing/selftests/net/fib_tests.sh | 483 +++++++++++++++---------------- 1 file changed, 237 insertions(+), 246 deletions(-) -- 2.11.0