From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Ahern Subject: [PATCH net-next 4/4] selftests: fib_tests: sleep after changing carrier Date: Tue, 13 Feb 2018 08:37:36 -0800 Message-ID: <20180213163736.1538-5-dsahern@gmail.com> References: <20180213163736.1538-1-dsahern@gmail.com> Cc: idosch@mellanox.com, David Ahern To: netdev@vger.kernel.org Return-path: Received: from mail-pg0-f47.google.com ([74.125.83.47]:40207 "EHLO mail-pg0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965272AbeBMQhr (ORCPT ); Tue, 13 Feb 2018 11:37:47 -0500 Received: by mail-pg0-f47.google.com with SMTP id g2so217304pgn.7 for ; Tue, 13 Feb 2018 08:37:47 -0800 (PST) In-Reply-To: <20180213163736.1538-1-dsahern@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: sleep for a second after setting carrier down to allow linkwatch to propagate the change to the routing stack via netdev_state_change. As it stands there is a race setting carrier down on the dummy device and then checking the linkdown flag in the routes. Signed-off-by: David Ahern --- tools/testing/selftests/net/fib_tests.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/testing/selftests/net/fib_tests.sh b/tools/testing/selftests/net/fib_tests.sh index e113cfd659fc..b617985ecdc1 100755 --- a/tools/testing/selftests/net/fib_tests.sh +++ b/tools/testing/selftests/net/fib_tests.sh @@ -282,6 +282,7 @@ fib_carrier_local_test() set -e ip -netns testns link set dev dummy0 carrier off + sleep 1 set +e echo " Carrier off on nexthop" -- 2.11.0