From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH V2 net-next 4/7] rds: support for zcopy completion notification Date: Wed, 14 Feb 2018 14:02:56 -0500 (EST) Message-ID: <20180214.140256.2107383260203156183.davem@davemloft.net> References: <331448b2-65d1-0f62-033c-b97d87a57b87@oracle.com> <20180214190110.GM11528@oracle.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: santosh.shilimkar@oracle.com, netdev@vger.kernel.org, willemdebruijn.kernel@gmail.com, rds-devel@oss.oracle.com To: sowmini.varadhan@oracle.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:57302 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1162459AbeBNTC6 (ORCPT ); Wed, 14 Feb 2018 14:02:58 -0500 In-Reply-To: <20180214190110.GM11528@oracle.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Sowmini Varadhan Date: Wed, 14 Feb 2018 14:01:10 -0500 > On (02/14/18 10:50), Santosh Shilimkar wrote: >> generic comment and please update it where it is applicable >> in terms of variable names, notifiers etc. >> >> RDS support true zero copy already with RDMA transport so some of >> this code can easily get confused. >> >> So I suggest something like below. >> s/zerocopy/zeromsgcopy >> s/zcopy/zmsgcopy >> s/zcookie/zmsgcpycookie >> s/znotifier/zmsgcpynotifier > > I'd like to hear some additional opinions from the list on this: > the existing socket API for TCP etc. already uses ZEROCOPY, and other > than extending variable names (and putting me at risk of violating the > "fit within 80 chars per line" requirement, leading to not-so-pretty > line wraps), I'm not seeing much value in this. I agree, this name change requires seems pointless. Just keep the names the way they are, thank you.