From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [net PATCH] Revert "net: thunderx: Add support for xdp redirect" Date: Wed, 14 Feb 2018 14:24:03 -0500 (EST) Message-ID: <20180214.142403.532212436685780119.davem@davemloft.net> References: <151854116184.18303.13476104443853509134.stgit@firesoul> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, sgoutham@cavium.com, aleksey.makarov@cavium.com, alexei.starovoitov@gmail.com, cjacob@caviumnetworks.com, borkmann@iogearbox.net, linux-arm-kernel@lists.infradead.org To: brouer@redhat.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:57618 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1162787AbeBNTYE (ORCPT ); Wed, 14 Feb 2018 14:24:04 -0500 In-Reply-To: <151854116184.18303.13476104443853509134.stgit@firesoul> Sender: netdev-owner@vger.kernel.org List-ID: From: Jesper Dangaard Brouer Date: Tue, 13 Feb 2018 17:59:22 +0100 > This reverts commit aa136d0c82fcd6af14535853c30e219e02b2692d. > > As I previously[1] pointed out this implementation of XDP_REDIRECT is > wrong. XDP_REDIRECT is a facility that must work between different > NIC drivers. Another NIC driver can call ndo_xdp_xmit/nicvf_xdp_xmit, > but your driver patch assumes payload data (at top of page) will > contain a queue index and a DMA addr, this is not true and worse will > likely contain garbage. > > Given you have not fixed this in due time (just reached v4.16-rc1), > the only option I see is a revert. > > [1] http://lkml.kernel.org/r/20171211130902.482513d3@redhat.com > > Cc: Sunil Goutham > Cc: Christina Jacob > Cc: Aleksey Makarov > Fixes: aa136d0c82fc ("net: thunderx: Add support for xdp redirect") > Signed-off-by: Jesper Dangaard Brouer Applied, thanks Jesper.