From: David Miller <davem@davemloft.net>
To: mcroce@redhat.com
Cc: netdev@vger.kernel.org, maheshb@google.com
Subject: Re: [PATCH 0/3] Remove IPVlan module dependencies on IPv6 and Netfilter
Date: Wed, 14 Feb 2018 20:11:03 -0500 (EST) [thread overview]
Message-ID: <20180214.201103.1477707468358595372.davem@davemloft.net> (raw)
In-Reply-To: <20180214181345.6368-1-mcroce@redhat.com>
From: Matteo Croce <mcroce@redhat.com>
Date: Wed, 14 Feb 2018 19:13:42 +0100
> The IPVlan module currently depends on IPv6 and Netfilter.
> Refactor the code to allow building IPVlan module regardless of the value of
> CONFIG_IPV6 and CONFIG_NETFILTER.
> Also change the dependency to CONFIG_NET_L3_MASTER_DEV into a select,
> as compiling L3 Master device alone has no sense.
As stated, the L3 master and netfilter are hard depenencies when using
ipvlan in some modes.
You can't just ifdef the driver like this, it changes fundamental
pieces of functionality.
I would say leave things as they are right now.
next prev parent reply other threads:[~2018-02-15 1:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-14 18:13 [PATCH 0/3] Remove IPVlan module dependencies on IPv6 and Netfilter Matteo Croce
2018-02-14 18:13 ` [PATCH 1/3] ipvlan: drop ipv6 dependency Matteo Croce
2018-02-14 18:13 ` [PATCH 2/3] ipvlan: drop netfilter dependency Matteo Croce
2018-02-14 18:13 ` [PATCH 3/3] ipvlan: selects master_l3 device instead of depending on it Matteo Croce
2018-02-14 23:01 ` [PATCH 0/3] Remove IPVlan module dependencies on IPv6 and Netfilter Florian Westphal
2018-02-15 1:11 ` David Miller [this message]
2018-02-15 14:04 ` Matteo Croce
2018-02-16 20:42 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180214.201103.1477707468358595372.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=maheshb@google.com \
--cc=mcroce@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).