From mboxrd@z Thu Jan  1 00:00:00 1970
From: hiren panchasara <hiren@strugglingcoder.info>
Subject: Re: A TLP implementation question
Date: Tue, 13 Feb 2018 23:39:58 -0800
Message-ID: <20180214073958.GI28312@strugglingcoder.info>
References: <20180214002751.GF28312@strugglingcoder.info>
 <CAK6E8=cE5UmR7d9-cBftGBd9o7zvzZtCm_eOX=XdQjBe04d-eA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="kr14OxHsRwZHHqxS"
Cc: netdev <netdev@vger.kernel.org>,
        Neal Cardwell <ncardwell@google.com>
To: Yuchung Cheng <ycheng@google.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from strugglingcoder.info ([104.236.146.68]:51642 "EHLO
        mail.strugglingcoder.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1754554AbeBNHjz (ORCPT
        <rfc822;netdev@vger.kernel.org>); Wed, 14 Feb 2018 02:39:55 -0500
Content-Disposition: inline
In-Reply-To: <CAK6E8=cE5UmR7d9-cBftGBd9o7zvzZtCm_eOX=XdQjBe04d-eA@mail.gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>


--kr14OxHsRwZHHqxS
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 02/13/18 at 05:11P, Yuchung Cheng wrote:
> On Tue, Feb 13, 2018 at 4:27 PM, hiren panchasara
> <hiren@strugglingcoder.info> wrote:
> >
> > Looking at current net-next to understand an aspect of TLP (tail loss
> > probe) implementation.
> >
> > https://tools.ietf.org/html/draft-ietf-tcpm-rack-02 is the source of
> > truth now for TLP and 6.2.1.  Phase 1: Scheduling a loss probe
> > Step 1: Check conditions for scheduling a PTO. has following as one of
> > the conditions:
> > (d) The most recently transmitted data was not itself a TLP probe
> > (i.e. a sender MUST NOT send consecutive TLP probes)
> this is done by
> 1) calling tcp_write_xmit(push_one=3D=3D2) in tcp_send_loss_probe()
> 2) avoid calling tcp_schedule_loss_probe() if push_one =3D=3D 2 in tcp_wr=
ite_xmit()
> 3) abort if one TLP probe is inflight by checking tlp_high_seq in
> tcp-send_loss_probe()
>=20
> consequently the sender will never schedule a PTO upon sending a probe
> (new or rtx) to avoid consecutive probes.
>=20
> hth.

Thanks a lot, Yuchung! I was missing this simple and now obvious thing
of not scheduling a pto upon sending a tlp. :-)

Cheers,
Hiren

--kr14OxHsRwZHHqxS
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQF8BAABCgBmBQJag+fLXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRBNEUyMEZBMUQ4Nzg4RjNGMTdFNjZGMDI4
QjkyNTBFMTU2M0VERkU1AAoJEIuSUOFWPt/lOssH/irq2DNq1dF30IxNVMc3IFPM
ZSIT1lfVRN425roIuEtDdX0M3Egg35sAGAfWhqj4zN9pBQEifHiTykdZXzYo/9Tl
ILybAqeqar5r/zUIV/sZtLwVmk8aNh6cGzXlUAuN/YDKq4bcGuehS6Q3PlkmGyRG
c1O9OwHEFAFuBdzsa1ftNngn1unDvREmSLEXtVOR47CFp+BZ8FlOWLK+2VlhCEmR
ZPa7GlfmAAnzpreOA2d7IzMiLxbtqFerZT4g1etUE9xbIET7pJ/AaaKT/hWwKIdt
toT7whBj1qBKMUvaC0aqQ1OjzUjEqO5Rn2n1HRmAe18OUMgaku8gUXvvEIqDQ2U=
=FLYu
-----END PGP SIGNATURE-----

--kr14OxHsRwZHHqxS--