From: Stephen Hemminger <stephen@networkplumber.org>
To: Serhey Popovych <serhe.popovych@gmail.com>
Cc: netdev@vger.kernel.org, dsahern@gmail.com
Subject: Re: [PATCH iproute2-next v2 2/9] ipaddress: ll_map: Replace ll_idx_n2a() with ll_index_to_name()
Date: Wed, 14 Feb 2018 14:05:25 -0800 [thread overview]
Message-ID: <20180214140525.10351021@xeon-e3> (raw)
In-Reply-To: <1518644024-12684-3-git-send-email-serhe.popovych@gmail.com>
On Wed, 14 Feb 2018 23:33:37 +0200
Serhey Popovych <serhe.popovych@gmail.com> wrote:
> if (tb[IFLA_MASTER]) {
> - SPRINT_BUF(b1);
> + int master = rta_getattr_u32(tb[IFLA_MASTER]);
>
> print_string(PRINT_ANY,
> "master",
> "master %s ",
> - ll_idx_n2a(rta_getattr_u32(tb[IFLA_MASTER]), b1));
> + ll_index_to_name(master));
Since this is an interface name, it should be printed in the correct color.
Sorry, missed that in the recent changes.
next prev parent reply other threads:[~2018-02-14 22:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-14 21:33 [PATCH iproute2-next v2 0/9] With this series I propose to make print_linkinfo_brief() static in Serhey Popovych
2018-02-14 21:33 ` [PATCH iproute2-next v2 1/9] ipaddress: Abstract IFA_LABEL matching code Serhey Popovych
2018-02-14 21:33 ` [PATCH iproute2-next v2 2/9] ipaddress: ll_map: Replace ll_idx_n2a() with ll_index_to_name() Serhey Popovych
2018-02-14 22:05 ` Stephen Hemminger [this message]
2018-02-14 21:33 ` [PATCH iproute2-next v2 3/9] utils: Reimplement ll_idx_n2a() and introduce ll_idx_a2n() Serhey Popovych
2018-02-14 21:33 ` [PATCH iproute2-next v2 4/9] ipaddress: Improve print_linkinfo() Serhey Popovych
2018-02-14 21:33 ` [PATCH iproute2-next v2 5/9] ipaddress: Simplify print_linkinfo_brief() and it's usage Serhey Popovych
2018-02-14 21:33 ` [PATCH iproute2-next v2 6/9] lib: Correct object file dependencies Serhey Popovych
2018-02-14 21:33 ` [PATCH iproute2-next v2 7/9] utils: Introduce and use get_ifname_rta() Serhey Popovych
2018-02-14 21:33 ` [PATCH iproute2-next v2 8/9] utils: Introduce and use print_name_and_link() to print name@link Serhey Popovych
2018-02-14 21:33 ` [PATCH iproute2-next v2 9/9] ipaddress: Make print_linkinfo_brief() static Serhey Popovych
2018-02-14 21:35 ` [PATCH iproute2-next v2 0/9] With this series I propose to make print_linkinfo_brief() static in Serhey Popovych
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180214140525.10351021@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=dsahern@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=serhe.popovych@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox