From: Stefano Brivio <sbrivio@redhat.com>
To: David Ahern <dsahern@gmail.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
Thomas Graf <tgraf@suug.ch>, Jianlin Shi <jishi@redhat.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH net] fib_semantics: Don't match route with mismatching tclassid
Date: Wed, 14 Feb 2018 19:06:37 +0100 [thread overview]
Message-ID: <20180214190637.428c19a5@epycfail> (raw)
In-Reply-To: <0b984dc9-1206-552f-80e4-66bac17c3ab1@gmail.com>
Hi David,
On Wed, 14 Feb 2018 10:46:05 -0700
David Ahern <dsahern@gmail.com> wrote:
> On 2/14/18 10:28 AM, Stefano Brivio wrote:
>
> > +#ifdef CONFIG_IP_ROUTE_CLASSID
> > + if (cfg->fc_flow != fi->fib_nh->nh_tclassid)
> > + return 1;
> > +#endif
>
> you should verify fc_flow is set. user is allowed to delete first
> matching route based on data that is given.
Thanks for your comment.
My intended semantic was different, that is, I assumed that if fc_flow
is not set (zero, here), the user shouldn't be able to just delete the
first matching route. But I guess your interpretation makes more sense
because it's consistent with the other checks. I'll send a v2.
--
Stefano
prev parent reply other threads:[~2018-02-14 18:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180214172822.25952-1-sbrivio@redhat.com>
2018-02-14 17:46 ` [PATCH net] fib_semantics: Don't match route with mismatching tclassid David Ahern
2018-02-14 18:06 ` Stefano Brivio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180214190637.428c19a5@epycfail \
--to=sbrivio@redhat.com \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=jishi@redhat.com \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox