* [PATCH net-next v2] selftests/net: fixes psock_fanout eBPF test case
@ 2018-02-15 0:19 Prashant Bhole
2018-02-15 0:22 ` Willem de Bruijn
2018-02-15 20:43 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Prashant Bhole @ 2018-02-15 0:19 UTC (permalink / raw)
To: David S . Miller; +Cc: Prashant Bhole, Shuah Khan, Willem de Bruijn, netdev
eBPF test fails due to verifier failure because log_buf is too small.
Fixed by increasing log_buf size
Signed-off-by: Prashant Bhole <bhole_prashant_q7@lab.ntt.co.jp>
---
v2: log_buf is statically allocated
tools/testing/selftests/net/psock_fanout.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tools/testing/selftests/net/psock_fanout.c b/tools/testing/selftests/net/psock_fanout.c
index 989f917068d1..d4346b16b2c1 100644
--- a/tools/testing/selftests/net/psock_fanout.c
+++ b/tools/testing/selftests/net/psock_fanout.c
@@ -128,6 +128,8 @@ static void sock_fanout_getopts(int fd, uint16_t *typeflags, uint16_t *group_id)
static void sock_fanout_set_ebpf(int fd)
{
+ static char log_buf[65536];
+
const int len_off = __builtin_offsetof(struct __sk_buff, len);
struct bpf_insn prog[] = {
{ BPF_ALU64 | BPF_MOV | BPF_X, 6, 1, 0, 0 },
@@ -140,7 +142,6 @@ static void sock_fanout_set_ebpf(int fd)
{ BPF_ALU | BPF_MOV | BPF_K, 0, 0, 0, 0 },
{ BPF_JMP | BPF_EXIT, 0, 0, 0, 0 }
};
- char log_buf[512];
union bpf_attr attr;
int pfd;
--
2.13.6
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net-next v2] selftests/net: fixes psock_fanout eBPF test case
2018-02-15 0:19 [PATCH net-next v2] selftests/net: fixes psock_fanout eBPF test case Prashant Bhole
@ 2018-02-15 0:22 ` Willem de Bruijn
2018-02-15 20:43 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Willem de Bruijn @ 2018-02-15 0:22 UTC (permalink / raw)
To: Prashant Bhole; +Cc: David S . Miller, Shuah Khan, Network Development
On Wed, Feb 14, 2018 at 7:19 PM, Prashant Bhole
<bhole_prashant_q7@lab.ntt.co.jp> wrote:
> eBPF test fails due to verifier failure because log_buf is too small.
> Fixed by increasing log_buf size
>
> Signed-off-by: Prashant Bhole <bhole_prashant_q7@lab.ntt.co.jp>
Acked-by: Willem de Bruijn <willemb@google.com>
Thanks Prashant.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next v2] selftests/net: fixes psock_fanout eBPF test case
2018-02-15 0:19 [PATCH net-next v2] selftests/net: fixes psock_fanout eBPF test case Prashant Bhole
2018-02-15 0:22 ` Willem de Bruijn
@ 2018-02-15 20:43 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2018-02-15 20:43 UTC (permalink / raw)
To: bhole_prashant_q7; +Cc: shuah, willemdebruijn.kernel, netdev
From: Prashant Bhole <bhole_prashant_q7@lab.ntt.co.jp>
Date: Thu, 15 Feb 2018 09:19:26 +0900
> eBPF test fails due to verifier failure because log_buf is too small.
> Fixed by increasing log_buf size
>
> Signed-off-by: Prashant Bhole <bhole_prashant_q7@lab.ntt.co.jp>
> ---
> v2: log_buf is statically allocated
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-02-15 20:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-02-15 0:19 [PATCH net-next v2] selftests/net: fixes psock_fanout eBPF test case Prashant Bhole
2018-02-15 0:22 ` Willem de Bruijn
2018-02-15 20:43 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).