From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH iproute2 2/7] devlink: mnlg: Add support for extended
 ack
Date: Thu, 15 Feb 2018 10:15:27 -0800
Message-ID: <20180215101527.6008687b@xeon-e3>
References: <1518598522-27713-1-git-send-email-arkadis@mellanox.com>
        <1518598522-27713-3-git-send-email-arkadis@mellanox.com>
        <20180214071206.4797e37b@xeon-e3>
        <078d8eaa-da4a-3c4c-0d82-817c3dd72a9a@mellanox.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org, davem@davemloft.net,
        dsa@cumulusnetworks.com, mlxsw@mellanox.com,
        Jiri Pirko <jiri@mellanox.com>
To: Arkadi Sharshevsky <arkadis@mellanox.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pl0-f68.google.com ([209.85.160.68]:46835 "EHLO
        mail-pl0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1163454AbeBOSPb (ORCPT
        <rfc822;netdev@vger.kernel.org>); Thu, 15 Feb 2018 13:15:31 -0500
Received: by mail-pl0-f68.google.com with SMTP id x19so261578plr.13
        for <netdev@vger.kernel.org>; Thu, 15 Feb 2018 10:15:31 -0800 (PST)
In-Reply-To: <078d8eaa-da4a-3c4c-0d82-817c3dd72a9a@mellanox.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Thu, 15 Feb 2018 13:57:18 +0200
Arkadi Sharshevsky <arkadis@mellanox.com> wrote:

> On 02/14/2018 05:12 PM, Stephen Hemminger wrote:
> > On Wed, 14 Feb 2018 10:55:17 +0200
> > Arkadi Sharshevsky <arkadis@mellanox.com> wrote:
> >   
> >> +static mnl_cb_t mnlg_cb_array[NLMSG_MIN_TYPE] = {
> >> +	[NLMSG_NOOP]	= mnlg_cb_noop,
> >> +	[NLMSG_ERROR]	= mnlg_cb_error,
> >> +	[NLMSG_DONE]	= mnlg_cb_stop,
> >> +	[NLMSG_OVERRUN]	= mnlg_cb_noop,
> >> +};
> >> +  
> > 
> > Could be const?
> >   
> 
> I pass the array to mnl_cb_run2() which will discard the 'const'
> qualifier. So I dont think this is very beneficial.

Thanks, makes sense,