From: Sowmini Varadhan <sowmini.varadhan@oracle.com>
To: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Cc: Network Development <netdev@vger.kernel.org>,
David Miller <davem@davemloft.net>,
rds-devel@oss.oracle.com,
Santosh Shilimkar <santosh.shilimkar@oracle.com>
Subject: Re: [PATCH V2 net-next 4/7] rds: support for zcopy completion notification
Date: Thu, 15 Feb 2018 07:03:31 -0500 [thread overview]
Message-ID: <20180215120331.GE24652@oracle.com> (raw)
In-Reply-To: <CAF=yD-+TCgGc6bBmrgbkxnR8pH43iPNnJkKuo+Zpvk7885AN3g@mail.gmail.com>
On (02/14/18 19:41), Willem de Bruijn wrote:
>
> One more thing: this code notifies that the operation succeeded, but
> the data was copied in the process. It does not have to be set otherwise.
I see. this one was a bit confusing for me (hence the copy/paste) -
maybe because the TCP/UDP/PACKET case is a bit different from RDS,
and sendmsg may find that it has to switch from zcopy to bcopy
after the sendmsg() itself has returned, but this cannot happen
for RDS (thus I should never set this code?).
Is it ok if I fix this in the next round or do you think
this warrants a V3?
--Sowmini
next prev parent reply other threads:[~2018-02-15 12:03 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-14 10:28 [PATCH V2 net-next 0/7] RDS: zerocopy support Sowmini Varadhan
2018-02-14 10:28 ` [PATCH V2 net-next 1/7] skbuff: export mm_[un]account_pinned_pages for other modules Sowmini Varadhan
2018-02-14 10:28 ` [PATCH V2 net-next 2/7] rds: hold a sock ref from rds_message to the rds_sock Sowmini Varadhan
2018-02-14 18:38 ` Santosh Shilimkar
2018-02-14 10:28 ` [PATCH V2 net-next 3/7] sock: permit SO_ZEROCOPY on PF_RDS socket Sowmini Varadhan
2018-02-14 10:28 ` [PATCH V2 net-next 4/7] rds: support for zcopy completion notification Sowmini Varadhan
2018-02-14 18:50 ` Santosh Shilimkar
2018-02-14 19:01 ` Sowmini Varadhan
2018-02-14 19:02 ` David Miller
2018-02-14 21:10 ` Santosh Shilimkar
2018-02-14 21:25 ` Sowmini Varadhan
2018-02-14 21:39 ` Santosh Shilimkar
2018-02-14 22:08 ` Santosh Shilimkar
2018-02-14 19:17 ` Santosh Shilimkar
2018-02-14 22:26 ` Willem de Bruijn
2018-02-15 0:19 ` Santosh Shilimkar
2018-02-15 0:12 ` Willem de Bruijn
2018-02-15 0:41 ` Willem de Bruijn
2018-02-15 12:03 ` Sowmini Varadhan [this message]
2018-02-15 16:35 ` Willem de Bruijn
2018-02-15 16:43 ` Sowmini Varadhan
2018-02-14 10:28 ` [PATCH V2 net-next 5/7] rds: zerocopy Tx support Sowmini Varadhan
2018-02-14 19:10 ` Santosh Shilimkar
2018-02-14 19:49 ` Sowmini Varadhan
2018-02-14 21:14 ` Santosh Shilimkar
2018-02-14 23:48 ` Willem de Bruijn
2018-02-15 0:09 ` Sowmini Varadhan
2018-02-15 0:15 ` Willem de Bruijn
2018-02-14 10:28 ` [PATCH V2 net-next 6/7] selftests/net: add support for PF_RDS sockets Sowmini Varadhan
2018-02-14 10:28 ` [PATCH V2 net-next 7/7] selftests/net: add zerocopy support for PF_RDS test case Sowmini Varadhan
2018-02-15 0:19 ` [PATCH V2 net-next 0/7] RDS: zerocopy support Willem de Bruijn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180215120331.GE24652@oracle.com \
--to=sowmini.varadhan@oracle.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=rds-devel@oss.oracle.com \
--cc=santosh.shilimkar@oracle.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).