From mboxrd@z Thu Jan  1 00:00:00 1970
From: Sowmini Varadhan <sowmini.varadhan@oracle.com>
Subject: Re: [PATCH V2 net-next 4/7] rds: support for zcopy completion
 notification
Date: Thu, 15 Feb 2018 07:03:31 -0500
Message-ID: <20180215120331.GE24652@oracle.com>
References: <cover.1517843755.git.sowmini.varadhan@oracle.com>
 <f9cf8d59bed78822f177364eea8e3f55f197776b.1517843755.git.sowmini.varadhan@oracle.com>
 <CAF=yD-+TCgGc6bBmrgbkxnR8pH43iPNnJkKuo+Zpvk7885AN3g@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Network Development <netdev@vger.kernel.org>,
        David Miller <davem@davemloft.net>, rds-devel@oss.oracle.com,
        Santosh Shilimkar <santosh.shilimkar@oracle.com>
To: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from userp2130.oracle.com ([156.151.31.86]:55436 "EHLO
        userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S967843AbeBOMDj (ORCPT
        <rfc822;netdev@vger.kernel.org>); Thu, 15 Feb 2018 07:03:39 -0500
Content-Disposition: inline
In-Reply-To: <CAF=yD-+TCgGc6bBmrgbkxnR8pH43iPNnJkKuo+Zpvk7885AN3g@mail.gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On (02/14/18 19:41), Willem de Bruijn wrote:
> 
> One more thing: this code notifies that the operation succeeded, but
> the data was copied in the process. It does not have to be set otherwise.

I see. this one was a bit confusing for me (hence the copy/paste) -
maybe because the TCP/UDP/PACKET case is a bit different from RDS,
and sendmsg may find that it has to switch from zcopy to bcopy 
after the sendmsg() itself has returned, but this cannot happen
for RDS (thus I should never set this code?).

Is it ok if I fix this in the next round or do you think
this warrants a V3?

--Sowmini