From: Dave Watson <davejwatson@fb.com>
To: Atul Gupta <atul.gupta@chelsio.com>
Cc: <davem@davemloft.net>, <herbert@gondor.apana.org.au>,
<sd@queasysnail.net>, <linux-crypto@vger.kernel.org>,
<netdev@vger.kernel.org>, <ganeshgr@chelsio.com>
Subject: Re: [Crypto v5 03/12] support for inline tls
Date: Thu, 15 Feb 2018 07:51:57 -0800 [thread overview]
Message-ID: <20180215155157.GA32691@davejwatson-mba> (raw)
In-Reply-To: <1518677694-28448-4-git-send-email-atul.gupta@chelsio.com>
On 02/15/18 12:24 PM, Atul Gupta wrote:
> @@ -401,6 +430,15 @@ static int do_tls_setsockopt_tx(struct sock *sk, char __user *optval,
> goto out;
> }
>
> + rc = get_tls_offload_dev(sk);
> + if (rc) {
> + goto out;
> + } else {
> + /* Retain HW unhash for cleanup and move to SW Tx */
> + sk->sk_prot[TLS_BASE_TX].unhash =
> + sk->sk_prot[TLS_FULL_HW].unhash;
Isn't sk->sk_prot a pointer to a global shared struct here still? It
looks like this would actually modify the global struct, and not just
for this sk.
next prev parent reply other threads:[~2018-02-15 15:51 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-15 6:54 [Crypto v5 00/12] Chelsio Inline TLS Atul Gupta
2018-02-15 6:54 ` [Crypto v5 01/12] tls: tls_device struct to register TLS drivers Atul Gupta
2018-02-15 6:54 ` [Crypto v5 02/12] ethtool: feature for Inline TLS in HW Atul Gupta
2018-02-15 6:54 ` [Crypto v5 03/12] support for inline tls Atul Gupta
2018-02-15 15:51 ` Dave Watson [this message]
2018-02-15 16:10 ` Atul Gupta
2018-02-15 16:26 ` Dave Watson
2018-02-15 16:31 ` Atul Gupta
2018-02-15 6:54 ` [Crypto v5 04/12] chtls: structure and macro definiton Atul Gupta
2018-02-15 6:54 ` [Crypto v5 05/12] cxgb4: Inline TLS FW Interface Atul Gupta
2018-02-15 6:54 ` [Crypto v5 06/12] cxgb4: LLD driver changes to enable TLS Atul Gupta
2018-02-15 6:54 ` [Crypto v5 07/12] chcr: Key Macro Atul Gupta
2018-02-15 6:54 ` [Crypto v5 08/12] chtls: Key program Atul Gupta
2018-02-15 6:54 ` [Crypto v5 09/12] chtls: CPL handler definition Atul Gupta
2018-02-15 6:54 ` [Crypto v5 10/12] chtls: Inline crypto request Tx/Rx Atul Gupta
2018-02-15 6:54 ` [Crypto v5 11/12] chtls: Register the chtls Inline TLS with net tls Atul Gupta
2018-02-15 6:54 ` [Crypto v5 12/12] Makefile Kconfig Atul Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180215155157.GA32691@davejwatson-mba \
--to=davejwatson@fb.com \
--cc=atul.gupta@chelsio.com \
--cc=davem@davemloft.net \
--cc=ganeshgr@chelsio.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sd@queasysnail.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox