From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next] cxgb4: append firmware dump to vmcore in kernel panic Date: Fri, 16 Feb 2018 15:41:01 -0500 (EST) Message-ID: <20180216.154101.1707041533181015167.davem@davemloft.net> References: <1518702882-29688-1-git-send-email-rahul.lakkireddy@chelsio.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, ganeshgr@chelsio.com, nirranjan@chelsio.com, indranil@chelsio.com To: rahul.lakkireddy@chelsio.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:58676 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750769AbeBPUlD (ORCPT ); Fri, 16 Feb 2018 15:41:03 -0500 In-Reply-To: <1518702882-29688-1-git-send-email-rahul.lakkireddy@chelsio.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Rahul Lakkireddy Date: Thu, 15 Feb 2018 19:24:42 +0530 > Register callback to panic_notifier_list. Invoke dump collect routine > to append dump to vmcore. > > Signed-off-by: Rahul Lakkireddy > Signed-off-by: Ganesh Goudar There is absolutely no precedence for a networking driver dumping things into the vmcore image on a panic. And I don't think this is a good idea. Really, this commit message should have explained why this is desired and in what context it is legitimate for this driver in particular to do it. A very detailed, long, complete commit message is especially important when you are deciding to blaze you own trail and do something no other networking driver has done before. I get really upset when I see changes like this, because you give me no preparation for what I'm about to read in the patch and therefore I have to go into this routine asking you to explain things properly. But as-is, I see this panic notifier as a really bad idea. Thanks.