From: David Miller <davem@davemloft.net>
To: dcaratti@redhat.com
Cc: jiri@resnulli.us, xiyou.wangcong@gmail.com, jhs@mojatatu.com,
netdev@vger.kernel.org
Subject: Re: [PATCH net] net: sched: fix unbalance in the error path of tca_action_flush()
Date: Fri, 16 Feb 2018 15:43:39 -0500 (EST) [thread overview]
Message-ID: <20180216.154339.783470229316014168.davem@davemloft.net> (raw)
In-Reply-To: <2254dab886c72ff9635b0d1a26e659d7bb31a55c.1518705847.git.dcaratti@redhat.com>
From: Davide Caratti <dcaratti@redhat.com>
Date: Thu, 15 Feb 2018 15:50:57 +0100
> When tca_action_flush() calls the action walk() and gets an error,
> a successful call to nla_nest_start() is not followed by a call to
> nla_nest_cancel(). It's harmless, as the skb is freed in the error
> path - but it's worth to fix this unbalance.
>
> Signed-off-by: Davide Caratti <dcaratti@redhat.com>
Applied to net-next, thanks.
prev parent reply other threads:[~2018-02-16 20:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-15 14:50 [PATCH net] net: sched: fix unbalance in the error path of tca_action_flush() Davide Caratti
2018-02-15 15:31 ` Jamal Hadi Salim
2018-02-15 19:05 ` Davide Caratti
2018-02-16 20:43 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180216.154339.783470229316014168.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dcaratti@redhat.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).