From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net] net: sched: fix unbalance in the error path of tca_action_flush() Date: Fri, 16 Feb 2018 15:43:39 -0500 (EST) Message-ID: <20180216.154339.783470229316014168.davem@davemloft.net> References: <2254dab886c72ff9635b0d1a26e659d7bb31a55c.1518705847.git.dcaratti@redhat.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: jiri@resnulli.us, xiyou.wangcong@gmail.com, jhs@mojatatu.com, netdev@vger.kernel.org To: dcaratti@redhat.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:58734 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750763AbeBPUnl (ORCPT ); Fri, 16 Feb 2018 15:43:41 -0500 In-Reply-To: <2254dab886c72ff9635b0d1a26e659d7bb31a55c.1518705847.git.dcaratti@redhat.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Davide Caratti Date: Thu, 15 Feb 2018 15:50:57 +0100 > When tca_action_flush() calls the action walk() and gets an error, > a successful call to nla_nest_start() is not followed by a call to > nla_nest_cancel(). It's harmless, as the skb is freed in the error > path - but it's worth to fix this unbalance. > > Signed-off-by: Davide Caratti Applied to net-next, thanks.