From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [PATCH net] tg3: APE heartbeat changes
Date: Fri, 16 Feb 2018 16:26:14 -0500 (EST)
Message-ID: <20180216.162614.1942583835571640040.davem@davemloft.net>
References: <1518755489-13652-1-git-send-email-satish.baddipadige@broadcom.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org, michael.chan@broadcom.com,
        prashant@broadcom.com, siva.kallam@broadcom.com,
        prashant.sreedharan@broadcom.com
To: satish.baddipadige@broadcom.com
Return-path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([184.105.139.130]:59246 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750727AbeBPV0Q (ORCPT
        <rfc822;netdev@vger.kernel.org>); Fri, 16 Feb 2018 16:26:16 -0500
In-Reply-To: <1518755489-13652-1-git-send-email-satish.baddipadige@broadcom.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Satish Baddipadige <satish.baddipadige@broadcom.com>
Date: Fri, 16 Feb 2018 10:01:29 +0530

> @@ -990,6 +984,18 @@ static void tg3_ape_driver_state_change(struct tg3 *tp, int kind)
>  	tg3_ape_send_event(tp, event);
>  }
>  
> +static inline void tg3_send_ape_heartbeat(struct tg3 *tp,

Inline functions are not appropriate in foo.c files, please drop the
inline keyword and let the compiler device.