From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pablo Neira Ayuso Subject: Re: [PATCH net] netfilter: xt_hashlimit: fix lock imbalance Date: Fri, 16 Feb 2018 15:00:38 +0100 Message-ID: <20180216140038.obgpbkgsnrmwerv7@salvia> References: <1518451908.3715.161.camel@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Florian Westphal , Vishwanath Pai , netdev To: Eric Dumazet Return-path: Received: from mail.us.es ([193.147.175.20]:42584 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1032862AbeBPOAo (ORCPT ); Fri, 16 Feb 2018 09:00:44 -0500 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id 1B7602EFEA7 for ; Fri, 16 Feb 2018 15:00:43 +0100 (CET) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 0C43DDA788 for ; Fri, 16 Feb 2018 15:00:43 +0100 (CET) Content-Disposition: inline In-Reply-To: <1518451908.3715.161.camel@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: On Mon, Feb 12, 2018 at 08:11:48AM -0800, Eric Dumazet wrote: > From: Eric Dumazet > > syszkaller found that rcu was not held in hashlimit_mt_common() > > We only need to enable BH at this point. Applied, thanks Eric! Sorry, this didn't get into my patchwork [1] for some reason, so it got lost. [1] https://patchwork.ozlabs.org/project/netfilter-devel/