From: Andrew Lunn <andrew@lunn.ch>
To: Paul Burton <paul.burton@mips.com>
Cc: netdev@vger.kernel.org, Hassan Naveed <hassan.naveed@mips.com>,
Matt Redfearn <matt.redfearn@mips.com>,
"David S . Miller" <davem@davemloft.net>,
linux-mips@linux-mips.org
Subject: Re: [PATCH v5 01/14] net: pch_gbe: Mark Minnow PHY reset GPIO active low
Date: Sat, 17 Feb 2018 23:14:36 +0100 [thread overview]
Message-ID: <20180217221436.GA21315@lunn.ch> (raw)
In-Reply-To: <20180217201037.3006-2-paul.burton@mips.com>
> @@ -2700,10 +2701,10 @@ static int pch_gbe_minnow_platform_init(struct pci_dev *pdev)
> return ret;
> }
>
> - gpio_set_value(gpio, 0);
> - usleep_range(1250, 1500);
> gpio_set_value(gpio, 1);
> usleep_range(1250, 1500);
> + gpio_set_value(gpio, 0);
> + usleep_range(1250, 1500);
Hi Paul
It would be better to rewrite and use the gpiod_ API. The GPIO core
would then handle active low/active high.
Andrew
next prev parent reply other threads:[~2018-02-17 22:14 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-17 20:10 [PATCH v5 00/14] net: pch_gbe: Fixes & MIPS support Paul Burton
2018-02-17 20:10 ` [PATCH v5 01/14] net: pch_gbe: Mark Minnow PHY reset GPIO active low Paul Burton
2018-02-17 22:14 ` Andrew Lunn [this message]
2018-02-17 20:10 ` [PATCH v5 02/14] net: pch_gbe: Pull PHY GPIO handling out of Minnow code Paul Burton
2018-02-17 22:29 ` Andrew Lunn
2018-02-17 22:50 ` Paul Burton
2018-02-17 23:34 ` Andrew Lunn
2018-02-18 15:51 ` Paul Burton
2018-02-18 16:14 ` Andrew Lunn
2018-02-17 20:10 ` [PATCH v5 03/14] dt-bindings: net: Document Intel pch_gbe binding Paul Burton
[not found] ` <20180217201037.3006-4-paul.burton-8NJIiSa5LzA@public.gmane.org>
2018-02-17 22:32 ` Andrew Lunn
2018-02-17 20:10 ` [PATCH v5 04/14] net: pch_gbe: Add device tree support Paul Burton
2018-02-17 20:10 ` [PATCH v5 05/14] net: pch_gbe: Always reset PHY along with MAC Paul Burton
2018-02-17 20:10 ` [PATCH v5 06/14] net: pch_gbe: Allow longer for resets Paul Burton
2018-02-18 15:29 ` kbuild test robot
2018-02-17 20:10 ` [PATCH v5 07/14] net: pch_gbe: Fix handling of TX padding Paul Burton
2018-02-19 14:01 ` David Laight
2018-02-19 16:42 ` Paul Burton
2018-02-19 16:41 ` David Miller
2018-02-17 20:10 ` [PATCH v5 08/14] net: pch_gbe: Fold pch_gbe_setup_[rt]ctl into pch_gbe_configure_[rt]x Paul Burton
2018-02-17 20:10 ` [PATCH v5 09/14] net: pch_gbe: Use pch_gbe_disable_dma_rx() in pch_gbe_configure_rx() Paul Burton
2018-02-17 20:10 ` [PATCH v5 10/14] net: pch_gbe: Disable TX DMA whilst configuring descriptors Paul Burton
2018-02-17 20:10 ` [PATCH v5 11/14] net: pch_gbe: Ensure DMA is ordered with descriptor writes Paul Burton
2018-02-17 20:10 ` [PATCH v5 12/14] net: pch_gbe: Fix TX RX descriptor accesses for big endian systems Paul Burton
2018-02-18 16:01 ` kbuild test robot
2018-02-17 20:10 ` [PATCH v5 13/14] ptp: pch: Allow build on MIPS platforms Paul Burton
2018-02-17 20:10 ` [PATCH v5 14/14] net: pch_gbe: " Paul Burton
2018-02-18 15:31 ` [PATCH v5 00/14] net: pch_gbe: Fixes & MIPS support David Miller
2018-02-18 17:03 ` Paul Burton
2018-02-18 17:56 ` Andrew Lunn
2018-02-18 22:09 ` Paul Burton
2018-02-19 1:15 ` David Miller
2018-02-19 2:17 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180217221436.GA21315@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=hassan.naveed@mips.com \
--cc=linux-mips@linux-mips.org \
--cc=matt.redfearn@mips.com \
--cc=netdev@vger.kernel.org \
--cc=paul.burton@mips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).