From: David Miller <davem@davemloft.net>
To: jiri@resnulli.us
Cc: netdev@vger.kernel.org, idosch@mellanox.com, alexpe@mellanox.com,
mlxsw@mellanox.com
Subject: Re: [patch net] mlxsw: spectrum_router: Do not unconditionally clear route offload indication
Date: Mon, 19 Feb 2018 11:21:45 -0500 (EST) [thread overview]
Message-ID: <20180219.112145.2203986653413259041.davem@davemloft.net> (raw)
In-Reply-To: <20180216233044.6323-1-jiri@resnulli.us>
From: Jiri Pirko <jiri@resnulli.us>
Date: Sat, 17 Feb 2018 00:30:44 +0100
> From: Ido Schimmel <idosch@mellanox.com>
>
> When mlxsw replaces (or deletes) a route it removes the offload
> indication from the replaced route. This is problematic for IPv4 routes,
> as the offload indication is stored in the fib_info which is usually
> shared between multiple routes.
>
> Instead of unconditionally clearing the offload indication, only clear
> it if no other route is using the fib_info.
>
> Fixes: 3984d1a89fe7 ("mlxsw: spectrum_router: Provide offload indication using nexthop flags")
> Signed-off-by: Ido Schimmel <idosch@mellanox.com>
> Reported-by: Alexander Petrovskiy <alexpe@mellanox.com>
> Tested-by: Alexander Petrovskiy <alexpe@mellanox.com>
> Signed-off-by: Jiri Pirko <jiri@mellanox.com>
> ---
> Dave, please, push to stable. Thanks!
Applied and queued up for -stable, thanks Jiri!
prev parent reply other threads:[~2018-02-19 16:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-16 23:30 [patch net] mlxsw: spectrum_router: Do not unconditionally clear route offload indication Jiri Pirko
2018-02-19 16:21 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180219.112145.2203986653413259041.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexpe@mellanox.com \
--cc=idosch@mellanox.com \
--cc=jiri@resnulli.us \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).