From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from shards.monkeyblade.net ([184.105.139.130]:32854 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752690AbeBSQVr (ORCPT ); Mon, 19 Feb 2018 11:21:47 -0500 Date: Mon, 19 Feb 2018 11:21:45 -0500 (EST) Message-Id: <20180219.112145.2203986653413259041.davem@davemloft.net> To: jiri@resnulli.us Cc: netdev@vger.kernel.org, idosch@mellanox.com, alexpe@mellanox.com, mlxsw@mellanox.com Subject: Re: [patch net] mlxsw: spectrum_router: Do not unconditionally clear route offload indication From: David Miller In-Reply-To: <20180216233044.6323-1-jiri@resnulli.us> References: <20180216233044.6323-1-jiri@resnulli.us> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org List-ID: From: Jiri Pirko Date: Sat, 17 Feb 2018 00:30:44 +0100 > From: Ido Schimmel > > When mlxsw replaces (or deletes) a route it removes the offload > indication from the replaced route. This is problematic for IPv4 routes, > as the offload indication is stored in the fib_info which is usually > shared between multiple routes. > > Instead of unconditionally clearing the offload indication, only clear > it if no other route is using the fib_info. > > Fixes: 3984d1a89fe7 ("mlxsw: spectrum_router: Provide offload indication using nexthop flags") > Signed-off-by: Ido Schimmel > Reported-by: Alexander Petrovskiy > Tested-by: Alexander Petrovskiy > Signed-off-by: Jiri Pirko > --- > Dave, please, push to stable. Thanks! Applied and queued up for -stable, thanks Jiri!