From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from shards.monkeyblade.net ([184.105.139.130]:33170 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753152AbeBSQlq (ORCPT ); Mon, 19 Feb 2018 11:41:46 -0500 Date: Mon, 19 Feb 2018 11:41:44 -0500 (EST) Message-Id: <20180219.114144.1093189940690873472.davem@davemloft.net> To: paul.burton@mips.com Cc: David.Laight@ACULAB.COM, netdev@vger.kernel.org, hassan.naveed@mips.com, matt.redfearn@mips.com, linux-mips@linux-mips.org Subject: Re: [PATCH v5 07/14] net: pch_gbe: Fix handling of TX padding From: David Miller In-Reply-To: <20180219164223.plclfvimcyiqzh4h@pburton-laptop> References: <20180217201037.3006-8-paul.burton@mips.com> <33d3777368d244a79c6287b2e955853f@AcuMS.aculab.com> <20180219164223.plclfvimcyiqzh4h@pburton-laptop> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org List-ID: From: Paul Burton Date: Mon, 19 Feb 2018 08:42:23 -0800 > So whilst I totally agree that copying around the whole frame is awful, > it's a separate problem to the length used for DMA mapping being > incorrect which is what this patch addresses & I'd rather not start > adding more & more fixes or cleanups into this initial series before the > driver is even functional on my hardware. Agreed.