From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from shards.monkeyblade.net ([184.105.139.130]:35108 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753443AbeBSTRO (ORCPT ); Mon, 19 Feb 2018 14:17:14 -0500 Date: Mon, 19 Feb 2018 14:17:12 -0500 (EST) Message-Id: <20180219.141712.271423476108125356.davem@davemloft.net> To: satish.baddipadige@broadcom.com Cc: netdev@vger.kernel.org, michael.chan@broadcom.com, prashant@broadcom.com, siva.kallam@broadcom.com, prashant.sreedharan@broadcom.com Subject: Re: [PATCH net] tg3: APE heartbeat changes From: David Miller In-Reply-To: <1519023424-15874-1-git-send-email-satish.baddipadige@broadcom.com> References: <1519023424-15874-1-git-send-email-satish.baddipadige@broadcom.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org List-ID: From: Satish Baddipadige Date: Mon, 19 Feb 2018 12:27:04 +0530 > From: Prashant Sreedharan > > In ungraceful host shutdown or driver crash case BMC connectivity is > lost. APE firmware is missing the driver state in this > case to keep the BMC connectivity alive. > This patch has below change to address this issue. > > Heartbeat mechanism with APE firmware. This heartbeat mechanism > is needed to notify the APE firmware about driver state. > > This patch also has the change in wait time for APE event from > 1ms to 20ms as there can be some delay in getting response. > > v2: Drop inline keyword as per David suggestion. > > Signed-off-by: Prashant Sreedharan > Signed-off-by: Satish Baddipadige > Signed-off-by: Siva Reddy Kallam > Acked-by: Michael Chan Looks good, applied, thank you.