From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([184.105.139.130]:35286 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753443AbeBSTa7 (ORCPT
        <rfc822;netdev@vger.kernel.org>); Mon, 19 Feb 2018 14:30:59 -0500
Date: Mon, 19 Feb 2018 14:30:57 -0500 (EST)
Message-Id: <20180219.143057.1751495030105842591.davem@davemloft.net>
To: tlfalcon@linux.vnet.ibm.com
Cc: netdev@vger.kernel.org, nfont@linux.vnet.ibm.com,
        jallen@linux.vnet.ibm.com
Subject: Re: [PATCH net] ibmvnic: Clean RX pools only during a hard reset
From: David Miller <davem@davemloft.net>
In-Reply-To: <93621ba4-4718-468d-5801-7c2f1b67c326@linux.vnet.ibm.com>
References: <1518970121-8539-1-git-send-email-tlfalcon@linux.vnet.ibm.com>
        <20180219.113732.1002575230879716489.davem@davemloft.net>
        <93621ba4-4718-468d-5801-7c2f1b67c326@linux.vnet.ibm.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Thomas Falcon <tlfalcon@linux.vnet.ibm.com>
Date: Mon, 19 Feb 2018 13:24:52 -0600

> Sorry, I should explain it better. It's not there is a double free.
> It's that the driver is receiving RX descriptors from the previous
> session for which socket buffers have been freed. The driver's
> polling routine tries to copy data to the socket buffer, but it's
> been freed, so it's trying to copy to a NULL pointer.

That's kinda hairy, is this resend of the old descriptors guaranteed
to always happen in this situation?

Maybe it's better to have some way for the RX descriptor receiving
path to detect this situation (is SKB slot NULL?) to handle the
problem there.

Thanks.