From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from shards.monkeyblade.net ([184.105.139.130]:35328 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753452AbeBSTib (ORCPT ); Mon, 19 Feb 2018 14:38:31 -0500 Date: Mon, 19 Feb 2018 14:38:29 -0500 (EST) Message-Id: <20180219.143829.842027434381717638.davem@davemloft.net> To: pabeni@redhat.com Cc: netdev@vger.kernel.org, jon.maloy@ericsson.com, ying.xue@windriver.com Subject: Re: [PATCH net-next] tipc: don't call sock_release() in atomic context From: David Miller In-Reply-To: <8857e1324da5cd7b9ebd79641eab1444418bcdcb.1519063117.git.pabeni@redhat.com> References: <8857e1324da5cd7b9ebd79641eab1444418bcdcb.1519063117.git.pabeni@redhat.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org List-ID: From: Paolo Abeni Date: Mon, 19 Feb 2018 19:02:24 +0100 > syzbot reported a scheduling while atomic issue at netns > destruction time: ... > This is caused by tipc_topsrv_stop() releasing the listener socket > with the idr lock held. This changeset addresses the issue moving > the release operation outside such lock. > > Reported-and-tested-by: syzbot+749d9d87c294c00ca856@syzkaller.appspotmail.com > Fixes: 0ef897be12b8 ("tipc: separate topology server listener socket from subcsriber sockets") > Signed-off-by: Paolo Abeni Applied, thanks Paolo.