From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net 2/4] net/8390: Fix msg_enable patch snafu Date: Mon, 19 Feb 2018 18:43:43 -0500 (EST) Message-ID: <20180219.184343.1801583131809551924.davem@davemloft.net> References: <20180219.141137.2095980245673495027.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux@armlinux.org.uk To: fthain@telegraphics.com.au Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org List-Id: netdev.vger.kernel.org From: Finn Thain Date: Tue, 20 Feb 2018 09:01:11 +1100 (AEDT) > On Mon, 19 Feb 2018, David Miller wrote: > >> From: Finn Thain >> Date: Sun, 18 Feb 2018 21:39:17 -0500 (EST) >> >> > The lib8390 module parameter 'msg_enable' doesn't do anything useful: >> > it causes an ancient version string to be logged. >> >> Since you are removing the last reference to this 'version' string >> you should remove it as well. >> >> I'm surprised the compiler doesn't warn about this. >> > > I compile-tested every 8390 module and I didn't come across any compiler > bugs. > > Please take another look. I think you'll find that lib8390.c is always > #included by a module which does define that symbol. But nothing references 'version' after you remove the log message. You can therefore delete it. And I'm politely asking you to. Thank you.