From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net 2/4] net/8390: Fix msg_enable patch snafu Date: Mon, 19 Feb 2018 23:15:23 -0500 (EST) Message-ID: <20180219.231523.2226814242777657736.davem@davemloft.net> References: <20180219.184343.1801583131809551924.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux@armlinux.org.uk To: fthain@telegraphics.com.au Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org List-Id: netdev.vger.kernel.org From: Finn Thain Date: Tue, 20 Feb 2018 11:42:26 +1100 (AEDT) > If there was an unused variables I would happily remove that too but the > 'version' string is not unused. The etherh.c and mac8390.c files both > include "lib8390.c" and in there you'll find the 'version' string used in > ethdev_setup(). My bad, thanks for being so patient with me :)