From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@vger.kernel.org>
Received: from mail-pf0-f196.google.com ([209.85.192.196]:43353 "EHLO
        mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751403AbeBTSkz (ORCPT
        <rfc822;netdev@vger.kernel.org>); Tue, 20 Feb 2018 13:40:55 -0500
Received: by mail-pf0-f196.google.com with SMTP id z14so2862993pfe.10
        for <netdev@vger.kernel.org>; Tue, 20 Feb 2018 10:40:55 -0800 (PST)
Date: Tue, 20 Feb 2018 10:40:48 -0800
From: Stephen Hemminger <stephen@networkplumber.org>
To: David Ahern <dsahern@gmail.com>
Cc: Sabrina Dubroca <sd@queasysnail.net>, netdev@vger.kernel.org,
        sbrivio@redhat.com, serhe.popovych@gmail.com
Subject: Re: [PATCH iproute2-next v2] ip link: add support to display
 extended tun attributes
Message-ID: <20180220104048.3a22d668@xeon-e3>
In-Reply-To: <676f02bb-d2eb-8fdb-5c56-f16338ecc162@gmail.com>
References: <2ee799472ddf052722c5682506223244ce272606.1519124425.git.sd@queasysnail.net>
        <676f02bb-d2eb-8fdb-5c56-f16338ecc162@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Tue, 20 Feb 2018 09:34:15 -0700
David Ahern <dsahern@gmail.com> wrote:

> On 2/20/18 5:43 AM, Sabrina Dubroca wrote:
> > Signed-off-by: Sabrina Dubroca <sd@queasysnail.net>
> > Reviewed-by: Stefano Brivio <sbrivio@redhat.com>
> > ---
> > v2: define print_onoff to print flags, fix checkpatch warnings, drop
> > header changes
> > 
> >  ip/iptuntap.c | 86 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> >  1 file changed, 86 insertions(+)  
> 
> applied to iproute2-next.
> 
> > 
> > diff --git a/ip/iptuntap.c b/ip/iptuntap.c
> > index 4628db2832b4..07253870472f 100644
> > --- a/ip/iptuntap.c
> > +++ b/ip/iptuntap.c
> > @@ -469,3 +469,89 @@ int do_iptuntap(int argc, char **argv)
> >  		*argv);
> >  	exit(-1);
> >  }
> > +
> > +static void print_owner(FILE *f, uid_t uid)
> > +{
> > +	struct passwd *pw = getpwuid(uid);
> > +
> > +	if (pw)
> > +		fprintf(f, "user %s ", pw->pw_name);
> > +	else
> > +		fprintf(f, "user %u ", uid);
> > +}
> > +
> > +static void print_group(FILE *f, gid_t gid)
> > +{
> > +	struct group *group = getgrgid(gid);
> > +
> > +	if (group)
> > +		fprintf(f, "group %s ", group->gr_name);
> > +	else
> > +		fprintf(f, "group %u ", gid);
> > +}
> > +  
> 
> 
> Those helpers can be re-used to make 'ip tuntap show' better too.

These should support JSON output.