From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.kernel.org ([198.145.29.99]:40238 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751533AbeBTMrZ (ORCPT ); Tue, 20 Feb 2018 07:47:25 -0500 From: Leon Romanovsky To: Stephen Hemminger Cc: Leon Romanovsky , David Ahern , netdev Subject: [PATCH iproute2] rdma: Avoid memory leak for skipper resource Date: Tue, 20 Feb 2018 14:47:18 +0200 Message-Id: <20180220124718.16750-1-leon@kernel.org> Sender: netdev-owner@vger.kernel.org List-ID: From: Leon Romanovsky The call to get_task_name() allocates memory which is not freed in case of skipping the object. Fixes: 8ecac46a60ff ("rdma: Add QP resource tracking information") Signed-off-by: Leon Romanovsky --- rdma/res.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/rdma/res.c b/rdma/res.c index 2a63e712..62f5c544 100644 --- a/rdma/res.c +++ b/rdma/res.c @@ -395,8 +395,10 @@ static int res_qp_parse_cb(const struct nlmsghdr *nlh, void *data) comm = get_task_name(pid); } - if (rd_check_is_filtered(rd, "pid", pid)) + if (rd_check_is_filtered(rd, "pid", pid)) { + free(comm); continue; + } if (nla_line[RDMA_NLDEV_ATTR_RES_KERN_NAME]) /* discard const from mnl_attr_get_str */ -- 2.16.1