From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f65.google.com ([74.125.83.65]:41723 "EHLO mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751667AbeBTXTG (ORCPT ); Tue, 20 Feb 2018 18:19:06 -0500 Received: by mail-pg0-f65.google.com with SMTP id t4so7730514pgp.8 for ; Tue, 20 Feb 2018 15:19:05 -0800 (PST) Date: Tue, 20 Feb 2018 15:18:57 -0800 From: Stephen Hemminger To: Kirill Tkhai Cc: davem@davemloft.net, nicolas.dichtel@6wind.com, vyasevic@redhat.com, paulmck@linux.vnet.ibm.com, vyasevich@gmail.com, mark.rutland@arm.com, gregkh@linuxfoundation.org, leonro@mellanox.com, avagin@virtuozzo.com, fw@strlen.de, roman.kapl@sysgo.com, netdev@vger.kernel.org Subject: Re: [PATCH 1/3] net: Kill net_mutex Message-ID: <20180220151857.542d7225@xeon-e3> In-Reply-To: <151903431795.8021.5069678488269142143.stgit@localhost.localdomain> References: <151903409491.8021.11032992295248447417.stgit@localhost.localdomain> <151903431795.8021.5069678488269142143.stgit@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org List-ID: On Mon, 19 Feb 2018 12:58:38 +0300 Kirill Tkhai wrote: > + struct list_head exit_list; /* To linked to call pernet exit > + * methods on dead net (net_sem > + * read locked), or to unregister > + * pernet ops (net_sem wr locked). > + */ Sorry, that comment is completely unparseable. Either you know what it does, and therefore comment is unnecessary Or change comment to a valid explanation of the semantics of the list. Maybe comments about locking model are best left to where it is used in the code.