From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@vger.kernel.org>
Received: from mail-pl0-f65.google.com ([209.85.160.65]:45723 "EHLO
        mail-pl0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751394AbeBUAE7 (ORCPT
        <rfc822;netdev@vger.kernel.org>); Tue, 20 Feb 2018 19:04:59 -0500
Received: by mail-pl0-f65.google.com with SMTP id p5so8364808plo.12
        for <netdev@vger.kernel.org>; Tue, 20 Feb 2018 16:04:58 -0800 (PST)
Date: Tue, 20 Feb 2018 16:04:55 -0800
From: Stephen Hemminger <stephen@networkplumber.org>
To: Vincent Bernat <vincent@bernat.im>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH iproute2-next] color: disable color when json output is
 requested
Message-ID: <20180220160455.1e89c0be@xeon-e3>
In-Reply-To: <20180220232804.10930-1-vincent@bernat.im>
References: <20180220232804.10930-1-vincent@bernat.im>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Wed, 21 Feb 2018 00:28:04 +0100
Vincent Bernat <vincent@bernat.im> wrote:

> Instead of declaring -color and -json exclusive, ignore -color when
> -json is provided. The rationale is to allow to put -color in an alias
> for ip while still being able to use -json. -color is merely a
> presentation suggestion and we can assume there is nothing to color in
> the JSON output.
> 
> Signed-off-by: Vincent Bernat <vincent@bernat.im>

Looks fine to me, this could even go into master.
Need to update man page and make sure behavior is consistent
across ip, tc, and bridge commands.