From: Stephen Hemminger <stephen@networkplumber.org>
To: netdev@vger.kernel.org
Cc: Stephen Hemminger <sthemmin@microsoft.com>,
Stephen Hemminger <stephen@networkplumber.org>
Subject: [PATCH iproute2-next] ip: don't colorize the master device
Date: Tue, 20 Feb 2018 11:08:46 -0800 [thread overview]
Message-ID: <20180220190846.17356-1-stephen@networkplumber.org> (raw)
From: Stephen Hemminger <sthemmin@microsoft.com>
Putting whole string "master eth0" in the interface name color
is wrong and confusing. Let's just turn color off for all attributes
of device.
Fixes: d92cc2d087b0 ("ipaddress: ll_map: Replace ll_idx_n2a() with ll_index_to_name()")
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
ip/ipaddress.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/ip/ipaddress.c b/ip/ipaddress.c
index 1380453984d5..768e2ed27e76 100644
--- a/ip/ipaddress.c
+++ b/ip/ipaddress.c
@@ -888,11 +888,9 @@ int print_linkinfo(const struct sockaddr_nl *who,
if (tb[IFLA_MASTER]) {
int master = rta_getattr_u32(tb[IFLA_MASTER]);
- print_color_string(PRINT_ANY,
- COLOR_IFNAME,
- "master",
- "master %s ",
- ll_index_to_name(master));
+ print_string(PRINT_ANY,
+ "master", "master %s ",
+ ll_index_to_name(master));
}
if (tb[IFLA_OPERSTATE])
--
2.16.1
next reply other threads:[~2018-02-20 19:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-20 19:08 Stephen Hemminger [this message]
2018-02-20 20:18 ` [PATCH iproute2-next] ip: don't colorize the master device David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180220190846.17356-1-stephen@networkplumber.org \
--to=stephen@networkplumber.org \
--cc=netdev@vger.kernel.org \
--cc=sthemmin@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).