From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from shards.monkeyblade.net ([184.105.139.130]:33316 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751537AbeBUSQw (ORCPT ); Wed, 21 Feb 2018 13:16:52 -0500 Date: Wed, 21 Feb 2018 13:16:51 -0500 (EST) Message-Id: <20180221.131651.456270980450367076.davem@davemloft.net> To: hkallweit1@gmail.com Cc: nic_swsd@realtek.com, netdev@vger.kernel.org Subject: Re: [PATCH net-next] r8169: remove not needed PHY soft reset in rtl8168e_2_hw_phy_config From: David Miller In-Reply-To: <533d7dbc-f17a-d9fd-e9c8-0a2452f4c899@gmail.com> References: <458747c2-ff50-7cb9-ce8b-441458703c02@gmail.com> <20180220.232748.29423773548892357.davem@davemloft.net> <533d7dbc-f17a-d9fd-e9c8-0a2452f4c899@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org List-ID: From: Heiner Kallweit Date: Wed, 21 Feb 2018 07:29:24 +0100 > Am 21.02.2018 um 05:27 schrieb David Miller: >> From: Heiner Kallweit >> Date: Tue, 20 Feb 2018 07:30:16 +0100 >> >>> rtl8169_init_phy() resets the PHY anyway after applying the chip-specific >>> PHY configuration. So we don't need to soft-reset the PHY as part of the >>> chip-specific configuration. >>> >>> Signed-off-by: Heiner Kallweit >> >> I'm not so comfortable with this. >> >> There are so many r8169 chip variants out there. >> >> And who knows, maybe one of them needs this second PHY reset or due to >> some way the driver is coded it is necessary. >> >> Unless you can test this change on every r8169 chip type, I'm very >> reluctant to apply this patch. >> > I understand the concern, the change however is in rtl8168e_2_hw_phy_config() > which is specific to chip version 34 (RTL8168evl). > On my system with this chip version the change didn't change system behavior. Ok, that does alleviate my concerns. Patch applied, thank you.