netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Phil Sutter <phil@nwl.cc>
To: Roman Kapl <code@rkapl.cz>
Cc: netdev@vger.kernel.org, "David S . Miller" <davem@davemloft.net>,
	Jiri Pirko <jiri@resnulli.us>,
	Cong Wang <xiyou.wangcong@gmail.com>,
	Jiri Benc <jbenc@redhat.com>
Subject: Re: [PATCH v2] sched: report if filter is too large to dump
Date: Wed, 21 Feb 2018 08:45:54 +0100	[thread overview]
Message-ID: <20180221074554.GE4196@orbyte.nwl.cc> (raw)
In-Reply-To: <20180219203251.30273-1-code@rkapl.cz>

Hi Roman,

On Mon, Feb 19, 2018 at 09:32:51PM +0100, Roman Kapl wrote:
> So far, if the filter was too large to fit in the allocated skb, the
> kernel did not return any error and stopped dumping. Modify the dumper
> so that it returns -EMSGSIZE when a filter fails to dump and it is the
> first filter in the skb. If we are not first, we will get a next chance
> with more room.
> 
> I understand this is pretty near to being an API change, but the
> original design (silent truncation) can be considered a bug.
> 
> Note: The error case can happen pretty easily if you create a filter
> with 32 actions and have 4kb pages. Also recent versions of iproute try
> to be clever with their buffer allocation size, which in turn leads to

I'm curious, what does it lead to? :)

Thanks, Phil

  parent reply	other threads:[~2018-02-21  7:45 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-19 20:32 [PATCH v2] sched: report if filter is too large to dump Roman Kapl
2018-02-20 10:49 ` Jiri Pirko
2018-02-20 18:43 ` Cong Wang
2018-02-21  2:58 ` David Miller
2018-02-21  7:45 ` Phil Sutter [this message]
2018-02-21  8:38   ` Roman Kapl
2018-02-21  8:42     ` Phil Sutter
2018-02-21  8:49       ` Roman Kapl
2018-02-21 15:21         ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180221074554.GE4196@orbyte.nwl.cc \
    --to=phil@nwl.cc \
    --cc=code@rkapl.cz \
    --cc=davem@davemloft.net \
    --cc=jbenc@redhat.com \
    --cc=jiri@resnulli.us \
    --cc=netdev@vger.kernel.org \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).